[WIP] Test Cilium 4.20-dev with KubeVirt#81428
Conversation
Replace deprecated isovalent/olm-for-cilium OLM manifest download with cilium CLI's install --dry-run to generate day-0 manifests. This aligns with the cucushift reference script's approach while preserving the day-0 nature of the step (manifests stored in SHARED_DIR for installer). Changes: - Download cilium CLI v0.19.2 and use it to render Helm chart manifests - Add cniVersion override ConfigMap manifest (OCPBUGS-86033 workaround) - Add SCC ClusterRoleBinding for cilium service accounts - Update CILIUM_VERSION from 1.13.9 to 1.19.4 - Add CILIUM_CLI_VERSION env var (default 0.19.2) to ref.yaml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add "deny ingress access to updated pod" test to the skip list in both kubevirt-baremetalds-conformance-cilium and mce-agent-metal3-conformance-cilium workflows. The test is flaky where Cilium reacts more slowly than OVN Kubernetes and this test is sensitive for timing. Some other tests for Network policies were skipped in the past as well, so adding one more to this category is probably not a big deal (low priority). See https://redhat.atlassian.net/browse/OCPQE-28785 for the details why the original ones were disabled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ev build Add CILIUM_REPOSITORY env var to allow overriding the Helm chart source, enabling testing with development builds from cilium-charts-dev. Update the kubevirt-baremetalds-conformance-cilium workflow to use Cilium 1.20.0-dev for validating KubeVirt fixes ahead of the stable release. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughReplaces Cilium OLM manifest installation with a ChangesCilium manifest generation and workflow wiring
Estimated code review effort: 3 (Moderate) | ~25 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-kubevirt-metal-conformance-cilium |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/step-registry/cilium/conf/cilium-conf-ref.yaml`:
- Around line 11-17: The Cilium defaults in cilium-conf are mismatched:
CILIUM_VERSION points to a dev build while CILIUM_REPOSITORY still targets the
stable chart repo. Update the default repository in the CILIUM_REPOSITORY entry
to the dev charts location, or change the CILIUM_VERSION default to a released
chart so the two defaults stay in sync. Use the CILIUM_VERSION and
CILIUM_REPOSITORY definitions in the cilium-conf ref to make the adjustment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 876fbb72-727a-480a-ad53-681a6b505197
📒 Files selected for processing (4)
ci-operator/step-registry/cilium/conf/cilium-conf-commands.shci-operator/step-registry/cilium/conf/cilium-conf-ref.yamlci-operator/step-registry/hypershift/kubevirt/baremetalds/conformance-cilium/hypershift-kubevirt-baremetalds-conformance-cilium-workflow.yamlci-operator/step-registry/hypershift/mce/agent/metal3/conformance/cilium/hypershift-mce-agent-metal3-conformance-cilium-workflow.yaml
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
…le in cucushift step Dev version 1.20.0-dev not found in quay.io/cilium/charts. Revert to 1.19.4 and add CILIUM_REPOSITORY env var to cucushift cilium ref. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Must be different from the port on hosted cluster in case of KubeVirt
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 71 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-kubevirt-metal-conformance-cilium |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mgencur: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
This PR updates OpenShift CI’s Cilium-enabled KubeVirt/HyperShift workflows to install Cilium more directly during cluster day-0 setup, make the Cilium chart/CLI inputs configurable, and align conformance networking behavior with Cilium.
Practically, it:
ci-operator/step-registry/cilium/conf/*) to generate day-0 CNI manifests viacilium install --dry-run(instead of downloading/unpacking OLM manifests), parameterizingCILIUM_VERSION,CILIUM_REPOSITORY, andCILIUM_CLI_VERSIONvia environment variables.ConfigMap, and a DNS-to-kube-apiserverCiliumNetworkPolicy), and applies the needed OpenShift privileged SCC binding for installation.tunnelPort=4790in the management setup andtunnelPort=4789for the hosted/extended Hypershift path.ci-operator/step-registry/hypershift/kubevirt/...) to run the new Cilium config step, includecilium-dumpin teardown, switch the installed network type fromOVNKubernetestoCilium, and refineTEST_SKIPSto match updated Cilium/network-policy expectations.ci-operator/step-registry/cucushift/hypershift-extended/cilium/*) so thecilium installcommand uses--repository "${CILIUM_REPOSITORY}"(defaulting tooci://quay.io/cilium/charts/cilium), and updates associated skip patterns in the MCE metal3 conformance workflow.