Skip to content

ROSAENG-61074: extend ROSA advanced presubmit time budget#81419

Open
olucasfreitas wants to merge 1 commit into
openshift:mainfrom
olucasfreitas:ROSAENG-61074-rosa-advanced-timeout
Open

ROSAENG-61074: extend ROSA advanced presubmit time budget#81419
olucasfreitas wants to merge 1 commit into
openshift:mainfrom
olucasfreitas:ROSAENG-61074-rosa-advanced-timeout

Conversation

@olucasfreitas

@olucasfreitas olucasfreitas commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an explicit 6h0m0s timeout to the pr-rosa-hcp-advanced and pr-rosa-sts-advanced ci-operator tests
  • keep the change scoped to those two advanced ROSA presubmits instead of broadening the shared rosa-tests-pull-request chain
  • update the generated Prow job configuration so those jobs carry extra overhead for cluster setup, test execution, and teardown

Test plan

  • make ci-operator-config
  • Reviewed the ci-operator source and generated Prow diff for the two affected jobs
  • PR CI

Local note: the repo-wide ci-operator-checkconfig command fails in this environment with failed to create CI Op config agent: too many open files, and direct ci-operator-prowgen invocations do not resolve the existing oex-aws-qe cluster profile here. PR CI is the authoritative validation path for this change.

Summary by CodeRabbit

This PR updates the OpenShift CI configuration used by the ROSA (release) advanced presubmits to reduce timeout-related failures. It adds an explicit timeout: 6h0m0s to the pr-rosa-hcp-advanced and pr-rosa-sts-advanced ci-operator workflows, keeping the change scoped to these two advanced chains rather than modifying the shared rosa-tests-pull-request presubmit chain.

Along with the ci-operator source update, the generated Prow job configuration was refreshed so the affected jobs include the additional overhead needed for cluster setup, test execution, and teardown.

Test/verification plan is to run make ci-operator-config and review both the ci-operator source and the generated Prow diff (CI is still pending).

@openshift-ci-robot

openshift-ci-robot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@olucasfreitas: This pull request references ROSAENG-61074 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • add an explicit 6h0m0s timeout to the pr-rosa-hcp-advanced and pr-rosa-sts-advanced ci-operator tests
  • keep the change scoped to those two advanced ROSA presubmits instead of broadening the shared rosa-tests-pull-request chain
  • update the generated Prow job configuration so those jobs carry extra overhead for cluster setup, test execution, and teardown

Test plan

  • make ci-operator-config
  • Reviewed the ci-operator source and generated Prow diff for the two affected jobs
  • PR CI

Local note: the repo-wide ci-operator-checkconfig command fails in this environment with failed to create CI Op config agent: too many open files, and direct ci-operator-prowgen invocations do not resolve the existing oex-aws-qe cluster profile here. PR CI is the authoritative validation path for this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 07ea959d-0b8e-4ad7-9689-2a0f19385f71

📥 Commits

Reviewing files that changed from the base of the PR and between 5cb80da and 58902cc.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/rosa/openshift-rosa-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/rosa/openshift-rosa-master__e2e-presubmits.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/rosa/openshift-rosa-master__e2e-presubmits.yaml

Walkthrough

This change adds a timeout: 6h0m0s field to two ROSA e2e presubmit job configurations in the CI YAML.

Changes

ROSA e2e presubmit timeout config

Layer / File(s) Summary
Add job timeouts
ci-operator/config/openshift/rosa/openshift-rosa-master__e2e-presubmits.yaml
Adds timeout: 6h0m0s to the pr-rosa-hcp-advanced and pr-rosa-sts-advanced job configurations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: amandahla, davidleerh, gdbranco

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: extending the timeout for ROSA advanced presubmit jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator timeout fields changed in a YAML presubmit; no It/Describe/Context/When titles were added or modified.
Test Structure And Quality ✅ Passed Not applicable: this PR only adds ci-operator job timeouts in YAML; no Ginkgo test code, setup/cleanup, or assertions were changed.
Microshift Test Compatibility ✅ Passed PR only adds timeouts in a presubmit YAML; no new Ginkgo tests or unsupported MicroShift APIs/features were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only updates ci-operator YAML timeouts for two existing ROSA jobs; no new Ginkgo tests or SNO-unsafe test logic was added.
Topology-Aware Scheduling Compatibility ✅ Passed The change only adds timeout fields in presubmit YAML; no deployment/controller manifests or scheduling fields (affinity, nodeSelector, PDB, spread) were modified.
Ote Binary Stdout Contract ✅ Passed PR only changes ci-operator YAML timeouts; no process-level OTE code or stdout-writing setup was modified, so the stdout contract isn’t implicated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only YAML timeout fields changed; no new Ginkgo tests or network logic were added.
No-Weak-Crypto ✅ Passed Only YAML timeout additions are present; no weak-crypto strings, custom crypto, or secret comparisons appear in the changed ROSA config.
Container-Privileges ✅ Passed Only timeout fields were added for two ROSA presubmits; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear in the changed config.
No-Sensitive-Data-In-Logs ✅ Passed Only timeout fields were added in a YAML presubmit config; no log statements or sensitive-data patterns appear in the changed file.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from davidleerh and marcolan018 July 2, 2026 20:01
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2026
Add an explicit six-hour timeout to the ROSA HCP and STS advanced presubmits so they keep overhead for cluster setup, test execution, and teardown. Update the generated Prow jobs to keep the release repo in sync with the ci-operator source.
@olucasfreitas olucasfreitas force-pushed the ROSAENG-61074-rosa-advanced-timeout branch from 5cb80da to 58902cc Compare July 2, 2026 20:07
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@olucasfreitas: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-rosa-master-e2e-presubmits-pr-rosa-hcp-advanced openshift/rosa presubmit Ci-operator config changed
pull-ci-openshift-rosa-master-e2e-presubmits-pr-rosa-sts-advanced openshift/rosa presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@olucasfreitas

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@olucasfreitas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 2, 2026
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@olucasfreitas: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants