Adding three job profiles for migrating ipfailover test cases#81103
Adding three job profiles for migrating ipfailover test cases#81103melvinjoseph86 wants to merge 1 commit into
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughThis PR adds one ChangesOpenShift image CI jobs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: melvinjoseph86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/images/openshift-images-master.yaml`:
- Around line 58-122: The openshift-images-master config now defines new jobs,
but the generated downstream Prow job artifacts were not updated. Regenerate the
job configs with make update so the new entries from the config are reflected in
the files under ci-operator/jobs/openshift/images/, and commit those generated
changes alongside the config update.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 12fb29fa-d20f-46b0-a80e-6de9360d1fa7
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/images/openshift-images-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/images/openshift-images-master.yaml
| - as: tests-extension | ||
| run_if_changed: ^(tests-extension/) | ||
| steps: | ||
| test: | ||
| - as: sanity | ||
| commands: | | ||
| cd tests-extension | ||
| make verify | ||
| make build | ||
| make verify-metadata | ||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| - always_run: false | ||
| as: e2e-metal-ipi-tests-ext | ||
| optional: true | ||
| steps: | ||
| cluster_profile: equinix-ocp-metal | ||
| test: | ||
| - as: test | ||
| cli: latest | ||
| commands: | | ||
| cd tests-extension | ||
| make build | ||
| ./bin/ipfailover-tests-ext run-suite ipfailover/all --max-concurrency=1 | ||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| workflow: baremetalds-e2e-ovn-ipv4 | ||
| - always_run: false | ||
| as: e2e-openstack-ipi-tests-ext | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openstack-vexxhost | ||
| test: | ||
| - as: test | ||
| cli: latest | ||
| commands: | | ||
| cd tests-extension | ||
| make build | ||
| ./bin/ipfailover-tests-ext run-suite ipfailover/all --max-concurrency=1 | ||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| workflow: openshift-e2e-openstack-ipi | ||
| - always_run: false | ||
| as: e2e-vsphere-ovn-tests-ext | ||
| optional: true | ||
| steps: | ||
| cluster_profile: vsphere-elastic | ||
| test: | ||
| - as: test | ||
| cli: latest | ||
| commands: | | ||
| cd tests-extension | ||
| make build | ||
| ./bin/ipfailover-tests-ext run-suite ipfailover/all --max-concurrency=1 | ||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| workflow: openshift-e2e-vsphere-ovn |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Checking for generated Prow job files for openshift/images..."
fd -p 'openshift-images.*\.yaml$' ci-operator/jobs/
echo
echo "Looking for the newly added job names in generated job configs..."
rg -n -C2 'tests-extension|e2e-metal-ipi-tests-ext|e2e-openstack-ipi-tests-ext|e2e-vsphere-ovn-tests-ext' ci-operator/jobs/Repository: openshift/release
Length of output: 50374
Regenerate and include downstream Prow job artifacts.
The modified config file ci-operator/config/openshift/images/openshift-images-master.yaml adds four new tests (tests-extension, e2e-metal-ipi-tests-ext, e2e-openstack-ipi-tests-ext, e2e-vsphere-ovn-tests-ext), but the corresponding generated files in ci-operator/jobs/openshift/images/ do not contain these new job definitions.
Run make update to regenerate the Prow job configuration files and commit the resulting changes to ci-operator/jobs/.
[classify_review_comment]
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ci-operator/config/openshift/images/openshift-images-master.yaml` around
lines 58 - 122, The openshift-images-master config now defines new jobs, but the
generated downstream Prow job artifacts were not updated. Regenerate the job
configs with make update so the new entries from the config are reflected in the
files under ci-operator/jobs/openshift/images/, and commit those generated
changes alongside the config update.
Sources: Coding guidelines, Learnings
|
@melvinjoseph86: This PR was included in a payload test run from openshift/images#243 |
1 similar comment
|
@melvinjoseph86: This PR was included in a payload test run from openshift/images#243 |
|
/payload-job-with-prs pull-ci-openshift-images-master-e2e-metal-ipi-tests-ext images#243 |
|
@melvinjoseph86: the repo openshift/release does not contribute to the OpenShift official images, or the base branch is not currently having images promoted |
|
/payload-job-with-prs pull-ci-openshift-images-master-e2e-metal-ipi-tests-ext openshift/images#243 |
|
@melvinjoseph86: the repo openshift/release does not contribute to the OpenShift official images, or the base branch is not currently having images promoted |
|
/close |
|
@melvinjoseph86: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
Summary by CodeRabbit
This change updates the OpenShift CI configuration for
openshift/imagesto add test coverage for theipfailovermigration path. It introduces three new optional end-to-end jobs for Metal, OpenStack, and vSphere environments, each running theipfailovertest suite fromtests-extensionwith a single worker to keep execution serialized. These jobs expand CI validation across the major target platforms where the migrated test cases need to be verified.