OCPBUGS-84518: Remove exception for servicemesh-operator3 pod

[racheljpg]

Hello! This is a draft PR (want to get feedback and make sure I've done this correctly first).
I've made a draft PR at openshift-service-mesh/sail-operator#957 to add a terminationMessagePolicy to the servicemeshoperator3 container. Once this merges, this should mean this exception to the test can be removed here.
Thanks!

Summary by CodeRabbit

• Tests
  • Tightened monitor-test validation so previously ignored violations are now reported consistently.
• Bug Fixes
  • Cases that matched an older exception pattern may now fail instead of being silently treated as expected, improving test accuracy and reducing flaky results.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@racheljpg: This pull request references Jira Issue OCPBUGS-84518, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Hello! This is a draft PR (want to get feedback and make sure I've done this correctly first).
I've made a draft PR at openshift-service-mesh/sail-operator#957 to add a terminationMessagePolicy to the servicemeshoperator3 container. Once this merges, this should mean this exception to the test can be removed here.
Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: racheljpg
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 85a3d3cd-4440-46d4-b6b1-bd60cb69fe61

📥 Commits

Reviewing files that changed from the base of the PR and between f2c72ee and d885701.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

---

Walkthrough

This change removes a single grandfathered exemption entry from the existingViolations list in the termination message policy monitor test, specifically the entry for pods/servicemesh-operator3 in the openshift-operators namespace.

Changes

Termination Message Policy Exemption Removal

Layer / File(s)	Summary
Remove grandfathered violation entry pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go	The existingViolations entry exempting pods/servicemesh-operator3 in the openshift-operators namespace is removed, so matching failures are no longer automatically grandfathered as flaky.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing the exception for the servicemesh-operator3 pod.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The file has no Ginkgo It/Describe/Context/When titles; only JUnit names use namespace data, and the PR only removes an old violation exemption.
Test Structure And Quality	✅ Passed	PASS: The PR only removes one grandfathered violation entry; no Ginkgo tests, setup/cleanup, timeouts, or assertions were changed.
Microshift Test Compatibility	✅ Passed	Only a one-line removal in an existing monitor test; no new Ginkgo tests or MicroShift-incompatible APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Changed file is a monitor analyzer, not a Ginkgo e2e test; it only removes a namespace exemption and adds no multi-node/SNO assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Only removes a grandfathered test exception in monitor-test code; no manifests, replicas, affinity, nodeSelectors, or scheduling constraints were changed.
Ote Binary Stdout Contract	✅ Passed	The PR only deletes one grandfather-list entry in a monitor test; it adds no process-level stdout writes or suite setup changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a monitor-test grandfather-list entry was removed; no new Ginkgo e2e test or IPv4/external-connectivity logic was introduced.
No-Weak-Crypto	✅ Passed	The only touched test file contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons.
Container-Privileges	✅ Passed	PR only deletes a monitor-test grandfathering entry; no manifest/securityContext changes or privileged flags appear in the touched file.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The diff only removes one grandfathered namespace exception; no new logging/output was added, and existing JUnit output just reports pod/container names.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}