OCPBUGS-84521: remove openshift/cluster-machine-approver terminationMessagePolicy exemption

[twoGiants]

Summary

Remove the violation for cluster-machine-approver.

All containers in openshift/cluster-machine-approver have the TerminationMessagePolicy correctly set. The fix is in main for a while already:

• https://github.com/openshift/cluster-machine-approver/blob/main/manifests/04-deployment.yaml#L62
• https://github.com/openshift/cluster-machine-approver/blob/main/manifests/04-deployment-capi.yaml#L66

Additional Info

The kube-rbac-proxy sidecar in openshift/cluster-machine-approver had terminationMessagePolicy: File. The sidecar was removed in openshift/cluster-machine-approver@545d7e4883 (Jan 2026), so the exemption is no longer needed.

Fixes: https://issues.redhat.com/browse/OCPBUGS-84521

Summary by CodeRabbit

• Bug Fixes
  • Updated how existing termination message policy violations are handled, so one previously exempted namespace is no longer automatically treated as a flaky result.
  • As a result, matching issues in that area will now be reported more consistently instead of being silently grandfathered in.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@twoGiants: This pull request references Jira Issue OCPBUGS-84521, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Remove the violation for cluster-machine-approver.

All containers in openshift/cluster-machine-approver have the TerminationMessagePolicy correctly set. The fix is in main for a while already:

• https://github.com/openshift/cluster-machine-approver/blob/main/manifests/04-deployment.yaml#L62
• https://github.com/openshift/cluster-machine-approver/blob/main/manifests/04-deployment-capi.yaml#L66

Additional Info

The kube-rbac-proxy sidecar in openshift/cluster-machine-approver had terminationMessagePolicy: File. The sidecar was removed in openshift/cluster-machine-approver@545d7e4883 (Jan 2026), so the exemption is no longer needed.

Fixes: https://issues.redhat.com/browse/OCPBUGS-84521

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ab6c23e3-c933-48da-8936-ba62248df8cb

📥 Commits

Reviewing files that changed from the base of the PR and between 6bf37da and d1fca16.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

---

Walkthrough

Removed a grandfathered entry for the openshift-cluster-machine-approver namespace from the existingViolations map in the terminationmessagepolicy monitor test, so matching violations in that namespace are no longer automatically treated as pre-existing flakes.

Changes

Termination Message Policy Violation List

Layer / File(s)	Summary
Remove grandfathered violation entry pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go	Removes the openshift-cluster-machine-approver entry listing pods/machine-approver-capi from the existingViolations map, ending its automatic flake classification for terminationMessagePolicy violations.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately states the main change: removing the cluster-machine-approver terminationMessagePolicy exemption.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test titles were added or changed; the PR only removes one allowlist entry in a monitor test helper.
Test Structure And Quality	✅ Passed	PASS: PR only removes one grandfathered violation entry in a monitor analyzer; no Ginkgo It/BeforeEach/Eventually code or resource setup was changed.
Microshift Test Compatibility	✅ Passed	Patch only removes one grandfathered violation entry; no new Ginkgo tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only removes a monitor exemption in a non-Ginkgo analyzer file; no It/Describe/Context/When tests or SNO-multinode assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS - The only change is removing a monitor-test exemption; no deployment, controller, or scheduling logic was added or modified.
Ote Binary Stdout Contract	✅ Passed	Patch only removes one grandfathered violation entry; no main/init/TestMain/suite stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only removes one grandfathered violation entry in a monitor test helper; no new Ginkgo e2e tests or IPv4/external-connectivity code was added.
No-Weak-Crypto	✅ Passed	The only change removes a terminationMessagePolicy exemption; the modified file contains no crypto primitives or secret/token comparisons.
Container-Privileges	✅ Passed	The PR only removes a terminationMessagePolicy exemption in a Go monitor test; no manifest changes or privileged/hostNetwork/allowPrivilegeEscalation settings are introduced.
No-Sensitive-Data-In-Logs	✅ Passed	No logging changes; the patch only removes one exemption entry and the file contains no log statements or sensitive-data prints.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[twoGiants]

/jira refresh

[openshift-ci-robot]

@twoGiants: This pull request references Jira Issue OCPBUGS-84521, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[twoGiants]

/retest

[twoGiants]

Hi @sosiouxme and @raphaelvrosa !

I saw you reviewing and approving a similar PR so I am writing to you. And Luke, you're the creator of the bug ticket I am working on.

Could you PTAL? :) When it's approved and merged I'd backport it to releases-5.1|5.0|4.23.

[twoGiants]

/jira refresh

[openshift-ci-robot]

@twoGiants: This pull request references Jira Issue OCPBUGS-84521, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[twoGiants]

/test e2e-aws-csi

[twoGiants]

Ok, lets run then one more time.

/retest

[sosiouxme]

/approve
and if none of the jobs ever fail the test in question, then go for it... if the jobs are being too flaky on unrelated problems i can override them

[sosiouxme]

nevermind, the remaining test failures are clearly unrelated
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-gcp-ovn
/lgtm

[openshift-ci]

@sosiouxme: Overrode contexts on behalf of sosiouxme: ci/prow/e2e-aws-csi, ci/prow/e2e-gcp-ovn

Details

In response to this:

nevermind, the remaining test failures are clearly unrelated
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-gcp-ovn
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sosiouxme]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sosiouxme]

BTW this exemption didn't specifically exist in past releases, so you can't backport this PR, but you can backport the related fix for the test.

[twoGiants]

/verified

[openshift-ci-robot]

@twoGiants: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[twoGiants]

/verified by e2e and unit tests

[openshift-ci-robot]

@twoGiants: This PR has been marked as verified by e2e and unit tests.

Details

In response to this:

/verified by e2e and unit tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[twoGiants]

@sosiouxme the override for e2e-aws-csi didn't work. Tide is saying: Not mergeable. Job ci/prow/e2e-aws-csi has not succeeded.

[mdbooth]

Doubt I can do this here, but:

/override ci/prow/e2e-aws-csi

[openshift-ci]

@mdbooth: mdbooth unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

Doubt I can do this here, but:

/override ci/prow/e2e-aws-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mdbooth]

/retest-required

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD f2c72ee and 2 for PR HEAD d1fca16 in total

[openshift-ci]

@twoGiants: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-csi	d1fca16	link	true	/test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.