STOR-3029: Enable volume re-size offline tests for fsTypes 'ext4' and 'xfs'

[radeore]

Why we need this?
STOR-3028: OTE Migration of OTP storage tests to public repos

Summary

Extend the openshift/csi external storage suite with explicit ext4 and xfs volume-expand test patterns. Upstream volume-expand already covers default-fs offline/online resize; this adds fstype-specific coverage by registering Dynamic PV (ext4)(allowExpansion) and Dynamic PV (xfs)(allowExpansion) patterns via InitCustomVolumeExpandTestSuite, reusing existing upstream resize test logic without duplicating it.

Changes

• Add RegisterVolumeExpandFsTypeTests() in test/extended/storage/csi/volume_expand.go to append ext4/xfs allowExpansion patterns to testsuites.CSISuites
• Call it from InitCSITests() before driver manifest loading

Test run logs:

$ ./openshift-tests run 'openshift/csi' --dry-run | grep -F 'volume-expand'   | grep -Fe 'Dynamic PV (ext4)(allowExpansion)' -e 'Dynamic PV (xfs)(allowExpansion)' | ./openshift-tests run -f -
.
.
.
INFO[0905] Completed Builds test bucket in 1.265µs      
started: 0/1/6 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand should resize volume when PVC is edited while pod is using it"

started: 0/2/6 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand Verify if offline PVC expansion works"

started: 0/3/6 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand should resize volume when PVC is edited while pod is using it"

started: 0/4/6 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished"

started: 0/5/6 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand Verify if offline PVC expansion works"

started: 0/6/6 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished"

passed: (52.2s) 2026-06-30T18:10:36 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished"

passed: (52.6s) 2026-06-30T18:10:37 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand Verify if offline PVC expansion works"

passed: (58.5s) 2026-06-30T18:10:43 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished"

passed: (1m1s) 2026-06-30T18:10:45 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand Verify if offline PVC expansion works"

passed: (1m31s) 2026-06-30T18:11:15 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand should resize volume when PVC is edited while pod is using it"

passed: (1m48s) 2026-06-30T18:11:32 "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand should resize volume when PVC is edited while pod is using it"

Summary by CodeRabbit

• New Features
  • Added broader CSI volume expansion test coverage for common filesystem types, including ext4 and xfs.
  • Ensured these expansion checks are registered consistently before CSI driver manifests are loaded.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@radeore: This pull request references STOR-3029 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Why we need this?
OTE Migration efforts: OTP storage tests to public repo

Extend the openshift/csi external storage suite with explicit ext4 and xfs volume-expand test patterns. Upstream volume-expand already covers default-fs offline/online resize; this adds fstype-specific coverage by registering Dynamic PV (ext4)(allowExpansion) and Dynamic PV (xfs)(allowExpansion) patterns via InitCustomVolumeExpandTestSuite, reusing existing upstream resize test logic without duplicating it.

Changes

• Add RegisterVolumeExpandFsTypeTests() in test/extended/storage/csi/volume_expand.go to append ext4/xfs allowExpansion patterns to testsuites.CSISuites
• Call it from InitCSITests() before driver manifest loading

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

A new file test/extended/storage/csi/volume_expand.go defines ext4 and xfs dynamic PV patterns with AllowExpansion=true, builds a custom volume-expand test suite from them, and exposes RegisterVolumeExpandFsTypeTests (sync.Once-guarded). InitCSITests in pkg/clioptions/clusterdiscovery/csi.go is updated to call this registration before loading CSI driver manifests.

Changes

CSI Volume Expand FS-Type Test Registration

Layer / File(s)	Summary
Volume expand patterns, suite, and wiring test/extended/storage/csi/volume_expand.go, pkg/clioptions/clusterdiscovery/csi.go	Defines ext4 and xfs AllowExpansion=true dynamic PV patterns, constructs a custom volume-expand suite via InitCustomVolumeExpandTestSuite, registers it into testsuites.CSISuites using a sync.Once guard, and calls RegisterVolumeExpandFsTypeTests from InitCSITests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: enabling offline resize tests for ext4 and xfs filesystems.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The new CSI volume-expand patterns use fixed names, and the suite’s Ginkgo It titles are static strings with no dynamic identifiers.
Test Structure And Quality	✅ Passed	The changed file only registers CSI test patterns once; it contains no Ginkgo specs, assertions, or waits to review, and it matches existing suite-registration patterns.
Microshift Test Compatibility	✅ Passed	New code only registers ext4/xfs storageframework patterns; no new Ginkgo tests, OpenShift APIs, or MicroShift-unsupported features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo specs were added; the change only registers existing volume-expand patterns, with no multi-node assumptions to review.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only registers CSI test patterns and calls it during test init; no scheduling constraints, node selectors, anti-affinity, or topology logic were added.
Ote Binary Stdout Contract	✅ Passed	The added CSI registration helper only appends test patterns; it adds no stdout writes in init/main/suite setup paths.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The new helper only registers ext4/xfs CSI volume-expand storage patterns; no IPv4 literals, IP parsing, host URLs, or external connectivity are introduced.
No-Weak-Crypto	✅ Passed	Touched files only add CSI test registration/manifest loading; no MD5/SHA1/DES/RC4/3DES/ECB or secret-compare code appears in the changed paths.
Container-Privileges	✅ Passed	PR only adds CSI test registration code; no container/K8s manifests changed and no privileged/securityContext settings were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	No added logging of secrets/PII; the only new output prints manifest file paths, and the new helper adds no logs.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeore
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[radeore]

/retest-required

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@radeore: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	6a77516	link	true	/test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn	6a77516	link	true	/test e2e-vsphere-ovn
ci/prow/e2e-aws-csi	6a77516	link	true	/test e2e-aws-csi
ci/prow/e2e-gcp-csi	6a77516	link	true	/test e2e-gcp-csi
ci/prow/e2e-aws-ovn-microshift	6a77516	link	true	/test e2e-aws-ovn-microshift
ci/prow/e2e-gcp-ovn-upgrade	6a77516	link	true	/test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-trt]

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 6a77516

Job Name	New Test Risk
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand Verify if offline PVC expansion works" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand should resize volume when PVC is edited while pod is using it" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand Verify if offline PVC expansion works" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand should resize volume when PVC is edited while pod is using it" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 6a77516

• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand Verify if offline PVC expansion works" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (ext4)(allowExpansion)] volume-expand should resize volume when PVC is edited while pod is using it" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand Verify if offline PVC expansion works" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)(allowExpansion)] [Slow] volume-expand should resize volume when PVC is edited while pod is using it" [Total: 1, Pass: 1, Fail: 0, Flake: 0]