[release-4.21] OCPBUGS-94114: support Parents field on origin test suites by bshaw7 · Pull Request #31353 · openshift/origin

bshaw7 · 2026-06-30T14:34:09Z

Summary

Backport of origin#31261 (Parents field fix for openshift/conformance suite) to release-4.21.

Same change as the 4.22 backport PR #31270.

What it does

Adds Parents []string field to TestSuite struct
Adds mergeParentQualifiers() function for transitive qualifier propagation
Makes openshift/conformance/parallel and openshift/conformance/serial children of openshift/conformance
Removes hardcoded qualifier from parent so it inherits from children

Without this fix, openshift/conformance on 4.21 only picks up ~740 tests.
With this fix, it correctly aggregates ~4000+ tests from child suites.

Testing

Validated on master (origin#31261): conformance-validated showed 4700 tests
Validated on 4.22 (origin#31270): conformance-validated showed 4688 tests
Same diff applies cleanly to 4.21

/cc @stbenjam

…t suites Backport of origin#31261 to release-4.21. Adds Parents field to TestSuite struct and mergeParentQualifiers() function so that openshift/conformance parent suite inherits qualifiers from its parallel and serial children. Without this fix, openshift/conformance on 4.21 only picks up ~740 tests. With this fix, it correctly aggregates ~4000+ tests from child suites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot · 2026-06-30T14:34:16Z

@bshaw7: This pull request references Jira Issue OCPBUGS-94114, which is invalid:

expected Jira Issue OCPBUGS-94114 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of origin#31261 (Parents field fix for openshift/conformance suite) to release-4.21.

Same change as the 4.22 backport PR #31270.

What it does

Adds Parents []string field to TestSuite struct

Adds mergeParentQualifiers() function for transitive qualifier propagation

Makes openshift/conformance/parallel and openshift/conformance/serial children of openshift/conformance

Removes hardcoded qualifier from parent so it inherits from children

Without this fix, openshift/conformance on 4.21 only picks up ~740 tests.
With this fix, it correctly aggregates ~4000+ tests from child suites.

Testing

Validated on master (origin#31261): conformance-validated showed 4700 tests

Validated on 4.22 (origin#31270): conformance-validated showed 4688 tests

Same diff applies cleanly to 4.21

/cc @stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-30T14:34:19Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c281a3b1-a078-4922-8be3-9c3c09f4ce0c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

bshaw7 · 2026-06-30T14:34:21Z

/payload-job periodic-ci-openshift-release-main-nightly-4.21-opct-external-aws-ccm

openshift-ci · 2026-06-30T14:34:36Z

@bshaw7: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.21-opct-external-aws-ccm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9a6f1f0-7490-11f1-8a0a-2ee973cea65b-0

openshift-ci · 2026-06-30T14:37:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bshaw7
Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bshaw7 · 2026-07-01T06:13:25Z

CI tests shows expected count of 20-openshift-conformance-validated

Tue, 30 Jun 2026 19:43:37 UTC|3h39m10.74436171s> Global Status: post-processing
JOB_NAME                           | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
05-openshift-cluster-upgrade       | complete   |            | 1/1 (0 failures)          | complete                                          
10-openshift-kube-conformance      | complete   |            | 384/419 (0 failures)      | complete                                          
20-openshift-conformance-validated | complete   |            | 4486/4486 (16 failures)   | complete                                          
80-openshift-tests-replay          | complete   |            | 0/0 (0 failures)          | complete                                          
99-openshift-artifacts-collector   | complete   |            | 0/0 (0 failures)          | complete                                          
time="2026-06-30T19:43:37Z" level=info msg="Waiting for post-processor..."
Tue, 30 Jun 2026 19:48:37 UTC|3h44m10.741834898s> Global Status: complete
JOB_NAME                           | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
05-openshift-cluster-upgrade       | complete   | passed     | 1/1 (0 failures)          |                                                   
10-openshift-kube-conformance      | complete   | passed     | 384/419 (0 failures)      | Total tests processed: 386 (386 pass / 0 failed)  
20-openshift-conformance-validated | complete   | failed     | 4486/4486 (16 failures)   | Total tests processed: 1974 (1957 pass / 17 failed)
80-openshift-tests-replay          | complete   | passed     | 0/0 (0 failures)          |                                                   
99-openshift-artifacts-collector   | complete   | passed     | 0/0 (0 failures)          | Total tests processed: 16 (16 pass / 0 failed)    
time="2026-06-30T19:48:37Z" level=info msg="The execution has completed! Use retrieve command to collect the results and share the archive with your Red Hat partner."
2026-06-30 15:04:50+00:00> Done with code=0

bshaw7 · 2026-07-01T14:45:20Z

/jira refresh

openshift-ci-robot · 2026-07-01T14:45:25Z

@bshaw7: This pull request references Jira Issue OCPBUGS-94114, which is invalid:

expected dependent Jira Issue OCPBUGS-87838 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2026

openshift-ci Bot requested a review from stbenjam June 30, 2026 14:34

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release-4.21] OCPBUGS-94114: support Parents field on origin test suites#31353

[release-4.21] OCPBUGS-94114: support Parents field on origin test suites#31353
bshaw7 wants to merge 1 commit into
openshift:release-4.21from
bshaw7:backport-parents-fix-421

bshaw7 commented Jun 30, 2026

Uh oh!

openshift-ci-robot commented Jun 30, 2026

Summary

What it does

Testing

Uh oh!

coderabbitai Bot commented Jun 30, 2026

Review skipped

Uh oh!

bshaw7 commented Jun 30, 2026

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

bshaw7 commented Jul 1, 2026

Uh oh!

bshaw7 commented Jul 1, 2026

Uh oh!

openshift-ci-robot commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

bshaw7 commented Jun 30, 2026

Summary

What it does

Testing

Uh oh!

openshift-ci-robot commented Jun 30, 2026

Summary

What it does

Testing

Uh oh!

coderabbitai Bot commented Jun 30, 2026

Review skipped

Uh oh!

bshaw7 commented Jun 30, 2026

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

bshaw7 commented Jul 1, 2026

Uh oh!

bshaw7 commented Jul 1, 2026

Uh oh!

openshift-ci-robot commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants