Skip to content

[TEST] Broken verify commits 2 - does it pass CI? #698

Closed
tmshort wants to merge 1 commit intoopenshift:mainfrom
tmshort:broken-verify-commits2
Closed

[TEST] Broken verify commits 2 - does it pass CI? #698
tmshort wants to merge 1 commit intoopenshift:mainfrom
tmshort:broken-verify-commits2

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented Apr 15, 2026

This is at the tip of main

Summary by CodeRabbit

  • Documentation
    • Updated developer notes with formatting improvements and an additional note.

It does not include the upstream carry stuff

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Apr 15, 2026

/hold

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

Walkthrough

A terminating newline and a new paragraph containing "This is just a note, only a note." were added to the dev_notes.md file in the openshift directory.

Changes

Cohort / File(s) Summary
Documentation Update
openshift/dev_notes.md
Added terminating newline and appended note paragraph to development notes file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title '[TEST] Broken verify commits 2 - does it pass CI?' is unrelated to the actual changeset, which only adds a terminating newline and a note to openshift/dev_notes.md. Update the title to accurately reflect the changes, such as 'Add note to openshift/dev_notes.md' or similar, to match the actual file modifications.
Stable And Deterministic Test Names ❓ Inconclusive Cannot determine applicability of Ginkgo test names check without examining actual PR changes and file modifications. Please provide the actual git diff or list of modified files in the pull request to assess whether Ginkgo test files are affected.
✅ Passed checks (8 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable to this PR, which only modifies openshift/dev_notes.md, a developer documentation file, with no changes to any test files.
Microshift Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. The only file modified is openshift/dev_notes.md, a documentation file, which is not subject to the MicroShift Test Compatibility check.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies documentation file and does not add new e2e tests, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The custom check for topology-aware scheduling compatibility is not applicable to this PR. The PR modifies only openshift/dev_notes.md, a developer documentation file containing plain text notes. The check is specifically designed to flag scheduling constraints introduced in deployment manifests, operator code, or controllers that may break on non-HA OpenShift topologies. Since this PR contains no deployment manifests, no operator or controller modifications, and no scheduling constraints whatsoever, the check does not apply and appropriately passes.
Ote Binary Stdout Contract ✅ Passed PR only modifies documentation file openshift/dev_notes.md with no executable code changes, so no stdout writes in process-level code can violate the OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies a markdown documentation file with no test code additions, falling outside the scope of the IPv6 and disconnected network compatibility check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2026
@openshift-ci openshift-ci bot requested review from dtfranz and perdasilva April 15, 2026 19:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Apr 15, 2026

/approve cancel

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@openshift/dev_notes.md`:
- Line 6: Remove or replace the non-informative sentence "This is just a note,
only a note." in dev_notes.md: either delete that line or replace it with a
concrete developer note describing purpose, owner, action items or relevant
context (e.g., what the note refers to, who to contact, expected next steps) so
the document contains actionable information.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7da165eb-facc-4b38-8fd0-d70c81b37f57

📥 Commits

Reviewing files that changed from the base of the PR and between a3e5b4f and 425302f.

📒 Files selected for processing (1)
  • openshift/dev_notes.md

Comment thread openshift/dev_notes.md
[https://github.com/openshift/operator-framework-tooling/blob/main/README.md](https://github.com/openshift/operator-framework-tooling/blob/main/README.md) No newline at end of file
[https://github.com/openshift/operator-framework-tooling/blob/main/README.md](https://github.com/openshift/operator-framework-tooling/blob/main/README.md)

This is just a note, only a note.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove non-informative note text from developer docs.

This is just a note, only a note. doesn’t add actionable project context and creates noise in dev_notes.md. Please replace it with a concrete developer note (or remove it).

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@openshift/dev_notes.md` at line 6, Remove or replace the non-informative
sentence "This is just a note, only a note." in dev_notes.md: either delete that
line or replace it with a concrete developer note describing purpose, owner,
action items or relevant context (e.g., what the note refers to, who to contact,
expected next steps) so the document contains actionable information.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits 425302f link true /test verify-commits

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Apr 16, 2026

This appears to be resolved with openshift/release#77808

@tmshort tmshort closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant