Skip to content

OCPBUGS-77404: bugfix: use a system context for setting custom auth file path when fetching image sources#447

Open
everettraven wants to merge 1 commit into
openshift:masterfrom
everettraven:bugfix/OCPBUGS-77404
Open

OCPBUGS-77404: bugfix: use a system context for setting custom auth file path when fetching image sources#447
everettraven wants to merge 1 commit into
openshift:masterfrom
everettraven:bugfix/OCPBUGS-77404

Conversation

@everettraven

Copy link
Copy Markdown

so that the global pull secret can be mounted to the openshift-controller-manager pod as a volume and used when attempting to fetch image signatures for import.

…etching image sources

so that the global pull secret can be mounted to the openshift-controller-manager
pod as a volume and used when attempting to fetch image signatures for import.

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@everettraven: This pull request references Jira Issue OCPBUGS-77404, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

so that the global pull secret can be mounted to the openshift-controller-manager pod as a volume and used when attempting to fetch image signatures for import.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@everettraven: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn c237c92 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn c237c92 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ehearne-redhat

Copy link
Copy Markdown

After going through the other PR mentioned here, I can understand the need for this change. Since we are proposing to mount /etc/containers this change is needed for that. From the mentioned bug ticket, I can see at present that the controller-manager makes requests to quay.io and not the internal image registry. It seems it doesn't have access to that registry and bringing in this change will enable that as the config.json is read in this way.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants