OCPBUGS-95068: Close T-GM and T-BC phc2sys clock synchronization race conditions

[lack]

Synchronizing the system clock too early can lead to large time offsets
that settle slowly. By delaying phc2sys from running until the PHC is
"reasonably synchronized" (ie within 1.0s offset of a trusted
timesource), we ensure small offsets only which converge quickly.

For OC and BC, this means delaying phc2sys until ptp4l offset is <1.0s
(and in the case of mutli-profile BC, choosing the proper ptp4l to
evaluate is key). In GM, we delay phc2sys until ts2phc offset is <1.0s.

Cherry-picked from OCPBUGS-85586_phc2sys_ts2phc_race-4.22 (d2ff2d1)
and adapted for the 4.21 codebase (no hardwareconfig, alias, or
v2alpha1 APIs).

Fixes: OCPBUGS-85586

Assisted-by: Claude Opus 4.6 and pi.dev
Signed-off-by: Jim Ramsay jramsay@redhat.com

[openshift-ci]

@lack: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lack]

/jira cherry-pick OCPBUGS-94177

[openshift-ci-robot]

@lack: Jira Issue OCPBUGS-94177 has been cloned as Jira Issue OCPBUGS-95068. Will retitle bug to link to clone.
/retitle OCPBUGS-95068: Close T-GM and T-BC phc2sys clock synchronization race conditions

Details

In response to this:

/jira cherry-pick OCPBUGS-94177

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@lack: This pull request references Jira Issue OCPBUGS-95068, which is invalid:

• expected dependent Jira Issue OCPBUGS-94177 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Synchronizing the system clock too early can lead to large time offsets
that settle slowly. By delaying phc2sys from running until the PHC is
"reasonably synchronized" (ie within 1.0s offset of a trusted
timesource), we ensure small offsets only which converge quickly.

For OC and BC, this means delaying phc2sys until ptp4l offset is <1.0s
(and in the case of mutli-profile BC, choosing the proper ptp4l to
evaluate is key). In GM, we delay phc2sys until ts2phc offset is <1.0s.

Cherry-picked from OCPBUGS-85586_phc2sys_ts2phc_race-4.22 (d2ff2d1)
and adapted for the 4.21 codebase (no hardwareconfig, alias, or
v2alpha1 APIs).

Fixes: OCPBUGS-85586

Assisted-by: Claude Opus 4.6 and pi.dev
Signed-off-by: Jim Ramsay jramsay@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lack]

/jira refresh

[openshift-ci-robot]

@lack: This pull request references Jira Issue OCPBUGS-95068, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.z) matches configured target version for branch (4.21.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-94177 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-94177 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lack]

/label backport-risk-assessed

[lack]

/verified later @Bonnie-Block

[openshift-ci-robot]

@lack: This PR has been marked to be verified later by @Bonnie-Block.

Details

In response to this:

/verified later @Bonnie-Block

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lack]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@lack: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sebsoto]

/approve

[sebsoto]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lack, sebsoto
Once this PR has been reviewed and has the lgtm label, please assign josephdrichard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment