Skip to content

add vertex apikey for bundle tests#1694

Open
xrajesh wants to merge 1 commit into
openshift:mainfrom
xrajesh:xav/2026-06-03
Open

add vertex apikey for bundle tests#1694
xrajesh wants to merge 1 commit into
openshift:mainfrom
xrajesh:xav/2026-06-03

Conversation

@xrajesh
Copy link
Copy Markdown
Contributor

@xrajesh xrajesh commented Jun 3, 2026

Description

add vertex apikey for bundle tests

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Enhanced integration test infrastructure to support vertex credential authentication, improving test coverage for the service.

Signed-off-by: xavier <xavier@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cf3ca12a-df91-44ca-ac77-e2c05b4148fc

📥 Commits

Reviewing files that changed from the base of the PR and between 917277c and ac597c0.

📒 Files selected for processing (1)
  • .tekton/integration-tests/pipelines/lightspeed-service-integration-test-pipeline-4.19.yaml

📝 Walkthrough

Walkthrough

The Tekton pipeline for Lightspeed integration tests is updated to enable Vertex API provider testing. A new secret-backed volume vertex-token is added to the task, mounted at /var/run/vertex in the test container, and exposed via the VERTEX_PROVIDER_KEY_PATH environment variable.

Changes

Vertex Credential Configuration

Layer / File(s) Summary
Vertex credential wiring
.tekton/integration-tests/pipelines/lightspeed-service-integration-test-pipeline-4.19.yaml
Volume vertex-token is sourced from the vertex-apitoken secret, mounted at /var/run/vertex, and the path /var/run/vertex/token is exposed to the test step via the VERTEX_PROVIDER_KEY_PATH environment variable.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'add vertex apikey for bundle tests' clearly and specifically describes the main change: adding Vertex API key support to the integration test pipeline.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bparees and joshuawilson June 3, 2026 19:22
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2026

@xrajesh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant