4.19: OLS-3155: adding cluster claim#2043
Conversation
📝 WalkthroughWalkthroughThis PR updates a Tekton pipeline to replace static cluster provisioning with ephemeral cluster provisioning. The provision-ephemeral-cluster task is introduced with clusterClaim metadata, credentials are passed via Kubernetes secret reference to E2E tests, kubeconfig and password are extracted from that secret in the test execution, and cleanup is automated in the finally section. ChangesEphemeral Cluster Credential Flow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@JoaoFula: This pull request references OLS-3155 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
bf4ba70 to
11c3ea2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/integration-tests/lightspeed-console-pre-commit.yaml:
- Around line 55-58: Remove the undeclared PipelineTask parameters
prEventPayload and prEventHeaders from the Pipeline spec in
.tekton/integration-tests/lightspeed-console-pre-commit.yaml so the
provision-ephemeral-cluster task (openshift/konflux-tasks
tasks/provision-ephemeral-cluster/0.1) matches its declared contract; locate the
entries named prEventPayload and prEventHeaders and delete them. Also add or
ensure a step that runs Playwright browser installation (e.g., run npx
playwright install) before the E2E test step in the same pipeline so browsers
are available at test runtime.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: adf3bdb7-01e4-4145-97d2-8cff9f418b03
📒 Files selected for processing (1)
.tekton/integration-tests/lightspeed-console-pre-commit.yaml
…ssword removing e2e presubmits removing e2e presubmits
11c3ea2 to
11af4fe
Compare
|
/retest |
and changing getting kubeconfig, base url and password
Summary by CodeRabbit