Skip to content

4.19: OLS-3155: adding cluster claim#2043

Open
JoaoFula wants to merge 1 commit into
openshift:release-4.19from
JoaoFula:add-cluster-claim-4.19
Open

4.19: OLS-3155: adding cluster claim#2043
JoaoFula wants to merge 1 commit into
openshift:release-4.19from
JoaoFula:add-cluster-claim-4.19

Conversation

@JoaoFula

@JoaoFula JoaoFula commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

and changing getting kubeconfig, base url and password

Summary by CodeRabbit

  • Refactor
    • Updated cluster provisioning workflow to use ephemeral cluster provisioning instead of standard provisioning
    • Changed authentication credential handling to use Kubernetes secrets directly
    • Added automatic cluster deprovisioning at the end of test runs
    • Streamlined kubeconfig and credential sourcing logic

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR updates a Tekton pipeline to replace static cluster provisioning with ephemeral cluster provisioning. The provision-ephemeral-cluster task is introduced with clusterClaim metadata, credentials are passed via Kubernetes secret reference to E2E tests, kubeconfig and password are extracted from that secret in the test execution, and cleanup is automated in the finally section.

Changes

Ephemeral Cluster Credential Flow

Layer / File(s) Summary
Ephemeral cluster provisioning task
.tekton/integration-tests/lightspeed-console-pre-commit.yaml
Replaces previous cluster provisioning with new provision-ephemeral-cluster task, configured with clusterClaim metadata (architecture, cloud, region, variant, owner, product, timeout, version) and wired to run after eaas-provision-space and lint.
E2E test credential parameter wiring
.tekton/integration-tests/lightspeed-console-pre-commit.yaml
Updates ols-e2e-tests task to accept clusterCredentialsSecretRef parameter sourced from provision-ephemeral-cluster task result, and declares the parameter in taskSpec to enable subsequent steps to consume it.
E2E test credential usage and BASE_URL derivation
.tekton/integration-tests/lightspeed-console-pre-commit.yaml
Updates E2E test step to extract kubeconfig from clusterCredentialsSecretRef secret, writes kubeconfig file, derives LOGIN_PASSWORD from the same secret, computes BASE_URL using oc command against the provisioned cluster, and removes prior password-path extraction mechanism.
Cluster cleanup and downstream task updates
.tekton/integration-tests/lightspeed-console-pre-commit.yaml
Adds deprovision-ephemeral-cluster task in finally section parameterized from provision-ephemeral-cluster claim metadata, and updates gather-cluster-resources task to reference kubeconfig file path directly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 From static clusters to ephemeral flights,
Credentials flow through secrets so bright,
Each test now provisions its own little space,
Then cleans up the queue at a reasonable pace—
Tekton pipelines dancing with grace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title references adding cluster claim and the issue OLS-3155, which aligns with the main change in the changeset—replacing provision-cluster with provision-ephemeral-cluster and updating cluster credential handling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from kyoto and xrajesh June 4, 2026 08:21
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joaofula for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto kyoto changed the title OLS-3155 - adding cluster claim OLS-3155: adding cluster claim Jun 5, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 5, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 5, 2026

Copy link
Copy Markdown

@JoaoFula: This pull request references OLS-3155 which is a valid jira issue.

Details

In response to this:

and changing getting kubeconfig, base url and password

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoaoFula

JoaoFula commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@JoaoFula

JoaoFula commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@JoaoFula

JoaoFula commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@JoaoFula JoaoFula force-pushed the add-cluster-claim-4.19 branch from bf4ba70 to 11c3ea2 Compare June 8, 2026 08:41

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.tekton/integration-tests/lightspeed-console-pre-commit.yaml:
- Around line 55-58: Remove the undeclared PipelineTask parameters
prEventPayload and prEventHeaders from the Pipeline spec in
.tekton/integration-tests/lightspeed-console-pre-commit.yaml so the
provision-ephemeral-cluster task (openshift/konflux-tasks
tasks/provision-ephemeral-cluster/0.1) matches its declared contract; locate the
entries named prEventPayload and prEventHeaders and delete them. Also add or
ensure a step that runs Playwright browser installation (e.g., run npx
playwright install) before the E2E test step in the same pipeline so browsers
are available at test runtime.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: adf3bdb7-01e4-4145-97d2-8cff9f418b03

📥 Commits

Reviewing files that changed from the base of the PR and between c362249 and 11c3ea2.

📒 Files selected for processing (1)
  • .tekton/integration-tests/lightspeed-console-pre-commit.yaml

Comment thread .tekton/integration-tests/lightspeed-console-pre-commit.yaml Outdated
…ssword

removing e2e presubmits

removing e2e presubmits
@JoaoFula JoaoFula force-pushed the add-cluster-claim-4.19 branch from 11c3ea2 to 11af4fe Compare June 8, 2026 09:01
@JoaoFula

JoaoFula commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@kyoto kyoto changed the title OLS-3155: adding cluster claim 4.19: OLS-3155: adding cluster claim Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants