chore: reduce CVE surface in npm deps#7
Open
dsimansk wants to merge 3 commits into
Open
Conversation
Removed abandoned prettier-stylelint (not referenced, pulled ancient transitive deps). Upgraded webpack-dev-server 5.2.3->5.2.5, vitest+coverage-v8 4.1.5->4.1.9, mocha 11.7.5->11.7.6, cypress 15.11.0->15.17.0. Added yarn resolutions for launch-editor, shell-quote, and serialize-javascript to fix transitive CVEs including a critical shell-quote newline escape vulnerability. Total advisories reduced from 88 to 71 (critical 1->0, high 33->28). Co-Authored-By: Claude <noreply@anthropic.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
I see this is WIP, is there more to be done? |
Upgrade OCP Console SDK from 4.21 to 4.23 with all required dependency migrations: React 17->18, react-router 5->7, react-i18next 11->16, i18next 23->25, @testing-library/react 12->16. Remove unused Babel packages (@babel/core, @babel/preset-env, babel-loader) since webpack uses ts-loader. Remove Cypress and all related packages (cypress, mocha, mochawesome, @cypress/webpack-preprocessor, eslint-plugin-cypress). Cypress won't be used for e2e testing, Playwright will be used instead. Add yarn resolutions for transitive CVE fixes: fast-uri, flatted, follow-redirects, http-proxy-middleware, postcss, vite, ws, minimatch. CVE count reduced from 88 to 42. Remaining CVEs are upstream-constrained (SDK, react-router ~7.13.x) or dev-only transitive with no production exposure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Migrate from custom shell/JS i18n pipeline (build-i18n.sh, lexers.js, set-english-defaults.js) to i18next-cli with a TypeScript config. Drop unused pluralize dependency. Re-extract locale keys. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
Yep, I need a few iterations to get the correct approach. I.e. starting from console sdk bump, and then continue with what else can be updated. |
dsimansk
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@dsimansk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan