feat: add commit-msg hook and simplify session-commit#10
Conversation
Add Husky pre-commit (lint) and commit-msg hooks. The commit-msg hook validates conventional commit type prefix, authorship trailer (Co-Authored-By or Signed-off-by), and rejects em dashes. Merge, fixup, and squash commits are exempt. Simplify session-commit: remove progress log and blocker migration steps, add hook failure handling. Remove redundant commit-user command. Co-Authored-By: Claude <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cragsmann The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
| ## Steps | ||
|
|
||
| 1. **Assess changes** — run these in parallel: | ||
| 1. **Assess changes** -- run these in parallel: |
There was a problem hiding this comment.
Is it em dash vs. double dash styling per chat bot instance? :)
There was a problem hiding this comment.
Today he has some double dash mood
|
infra issue |
| @@ -0,0 +1,12 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
same reason as the above comment
| #!/usr/bin/env sh | |
| #!/usr/bin/env bash |
Co-authored-by: David Simansky <dsimansk@redhat.com>
|
@Cragsmann: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Does this complements or supersedes the other hook PR? |
It complements #6. I took the Husky setup commit from that PR to avoid duplicating the configuration. |
3 participants
Summary
Test plan