Fix metrics reporting for UDT#385
Merged
matteius merged 1 commit intoopensensor:mainfrom Apr 16, 2026
Merged
Conversation
* Fix reporting of sparklines for metrics * Allocate metrics slot for any metrics reporting * Instrument UDT with some basic metrics
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes and expands stream metrics reporting (including sparklines) by ensuring metrics slots are allocated when metrics are recorded, instrumenting Unified Detection Thread (UDT) with basic metrics, and adding smoothing to reported FPS/bitrate values.
Changes:
- Fix
/api/health?sparklines=...handling to correctly detect the query parameter. - Instrument UDT to record per-packet/frame metrics and recording lifecycle metrics.
- Update metrics slot allocation behavior and add basic EMA smoothing for FPS/bitrate sampling.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/web/api_handlers_health.c | Fixes query-param handling for enabling sparklines in the health response. |
| src/video/unified_detection_thread.c | Adds stream metrics recording (frames/bytes) and recording lifecycle metrics for UDT. |
| src/video/stream_state.c | Removes explicit metrics slot pre-allocation; relies on allocation via metrics APIs. |
| src/telemetry/stream_metrics.c | Changes slot allocation strategy, adds smoothing to sampled FPS/bitrate, and adjusts configured FPS usage. |
| include/telemetry/stream_metrics.h | Removes the public metrics_get_slot API from the header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.