feat(models): expose fueltech and renewable columns on TimeSeriesColumns#34
Merged
Merged
Conversation
When calling get_network_data with secondary_grouping='fueltech' or secondary_grouping='renewable', the API returns the grouping value in the result's columns object — but the SDK model only declared unit_code/fueltech_group/network_region, dropping these on parse. Add fueltech: str | None and renewable: bool | None so users can read the grouping from columns directly instead of parsing it out of the series name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced while validating #8: calling `get_network_data(secondary_grouping='fueltech' | 'renewable')` returns the grouping in the result's `columns` object, but `TimeSeriesColumns` only declared `unit_code`, `fueltech_group` and `network_region` — so the actual grouping value was silently dropped on parse and users had to fish it out of `result.name` (`"energy_solar_rooftop"`).
Change
```python
class TimeSeriesColumns(BaseModel):
unit_code: str | None = None
fueltech: str | None = None # NEW
fueltech_group: str | None = None
renewable: bool | None = None # NEW
network_region: str | None = None
```
Verified
Out of scope
`secondary_grouping='status'` returns a 500 from the API (separate server-side bug). Worth a tracking issue in `opennem/opennem`.