Document source label on gateway_function_invocation_inflight#432
Open
welteki wants to merge 1 commit into
Open
Document source label on gateway_function_invocation_inflight#432welteki wants to merge 1 commit into
welteki wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Add the new source label and its values to the inflight metric, correct the metric names for the started and inflight gauges, add a migration note for the increased cardinality, and clarify the difference between gateway-side and worker-side inflight metrics. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
eca08be to
038be88
Compare
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)9/10. The change is clear, scoped, and publishable; no blocking issues were found in the reviewed documentation diff. Summary per fileSummary per file
Overall AssessmentThe PR is ready from a review perspective. The added documentation is appropriately placed near the gateway metrics table, the internal anchors resolve to existing sections, and the migration note gives users a concrete PromQL pattern to preserve pre-upgrade behaviour. Detailed ReviewDetailed ReviewContent reviewNo blocking findings.
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents the new
sourcelabel ongateway_function_invocation_inflight,adds its values (
queue-worker,unknown) and a migration note for theincreased cardinality, notes why gateway and queue-worker inflight counts can
differ, and corrects the previously mistyped started/inflight metric names.
Motivation and Context
The gateway gained a
sourcelabel on the inflight invocation metric that wasnot yet documented.
How Has This Been Tested?
Ran the docs site locally with Docker and inspected the rendered page and links.
Types of changes
Checklist:
git commit -s