feat: add use of new filter for instructor dash tabs#38499
feat: add use of new filter for instructor dash tabs#38499holaontiveros wants to merge 7 commits into
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
wgu-taylor-payne
left a comment
There was a problem hiding this comment.
A couple of items to address, mostly around matching established conventions for filter consumers in this codebase. Also consider moving the filter call before the sort — currently plugin-added tabs will always appear at the end regardless of their sort_order, since the filter fires after sorting. No tests for the filter integration — other filter consumers in edx-platform have tests (e.g., test_instructor_dashboard.py tests InstructorDashboardRenderStarted).
Review assisted by Kiro
Description
In order to achieve openedx/frontend-app-instructor-dashboard#86 this PR will add use the new filter for the instructor dash tabs
depens on: openedx/openedx-filters#355
Once this is in place any operator / plugin creator can do something like:
in whichever shape fits their need to be able to conditionally add or modify data of the tabs for the instructor dashboard.
Testing instructions
Note: to test this through the API or the UI edx-filters changes need to be in place
Take in account that the frontend should have a slot to manage the URL that it's being returned for example a slot like this
is added to the frontend-base build then the
custom_analyticsfrom the path from the plugin example will match the tabIdcustom_analyticsfrom here and the tab will be displayedThe API request that uses this is:
http://local.openedx.io:8000/api/instructor/v2/courses/{:courseId}Deadline
None
Other information
Include anything else that will help reviewers and consumers understand the change.