feat(tiptap): add Tiptap toolbar support#2793
Open
tammi-23 wants to merge 1 commit into
Open
Conversation
JammingBen
reviewed
Jul 3, 2026
JammingBen
left a comment
JammingBen
left a comment
Member
There was a problem hiding this comment.
I'm not the biggest fan of this solution because it seems to be heavily tailored to the mail app. What if some other app wants to display a different set of toolbar items on mobile?
I'd rather have a more generalized mechanism of controlling which actions to display. Maybe introduce a actionsToDisplay prop on the toolbar which acts as a whitelist and defaults to undefined = all actions? The downside would be that the consuming party would require knowledge about the action ids. But it would keep the whole thing more abstract and not tailored to a specific implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds toolbar variants to the shared Tiptab text editor. The initial usecase is supporting different toolbar layouts for different mail compose sizes.