feat(tray): consistent back-links across cross-page navigations#521
feat(tray): consistent back-links across cross-page navigations#521bkudiess wants to merge 3 commits into
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 9, 2026, 3:01 PM ET / 19:01 UTC. Summary Reproducibility: not applicable. this is a tray UX feature PR rather than a bug report. The relevant check is visual proof of the changed Hub navigation states, and the posted screenshot only covers one shown-link state. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the focused tray UX change after representative visual proof covers both shown and hidden backlink states, and after the helper’s trailing blank lines are trimmed. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a tray UX feature PR rather than a bug report. The relevant check is visual proof of the changed Hub navigation states, and the posted screenshot only covers one shown-link state. Is this the best way to solve the issue? Yes, the implementation direction fits the existing HubWindow LastNavigationOrigin pattern and reuses localized sidebar labels. The remaining merge blockers are proof coverage for the promised behavior and a small EOF whitespace cleanup. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 71d249711d63. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
Extended the existing 'Back to Connection' affordance (Sessions/Instances/
Permissions) to every cross-page link in the Hub so users always have a
one-click return path.
- Added Helpers/NavOriginLabels for nav-tag -> display-label mapping so
destination pages can render 'Back to {origin}' dynamically.
- Threaded originTag through 9 cross-page Navigate calls: About->Debug,
Channels->Config (x2), Permissions->Voice, and Bindings/Cron/Usage/
Debug/Instances->Connection.
- Added the inline back HyperlinkButton + Initialize-time wiring to
ConfigPage, VoiceSettingsPage, DebugPage, and ConnectionPage matching
the existing Sessions/Instances/Permissions pattern.
- Updated AsyncListLoadingPageWiringTests to accept the originTag-bearing
Navigate('connection', ...) signature.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds consistent
← Back to {origin}affordances for cross-page navigations in the tray Hub. Destinations show the back link only when arriving from another page; rail/direct nav stays clean.Mechanism
originTag(e.g.Navigate(""voice"", ""chat"")).BackOriginLinkHyperlinkButton wired toRefreshBackOriginLink(); label comes fromNavOriginLabelswhich reuses the existing sidebarHubWindow_NavigationViewItem_*.Contentresw keys so page names stay translated and in sync.BackToOriginFormat(""Back to {0}"") +BackToOriginGeneric.Text(""Back""), localized in en-us / fr-fr / nl-nl / zh-cn / zh-tw.Cross-page connections wired
infobindingschannelschatconfigconnection(pre-existing)connection(pre-existing)connection(pre-existing)crondebuginstancespermissionsusageDestinations with dynamic back-link: Config, Connection, Debug, Voice. Sessions/Instances/Permissions keep their existing
BackToConnectionLink(only ever receiveconnectionorigin).Validation:

./build.ps1+ tray (934) + shared (2045) tests pass.