fix: remove abort event listener on successful fetch completion#1921
Open
Oxygen56 wants to merge 1 commit into
Open
fix: remove abort event listener on successful fetch completion#1921Oxygen56 wants to merge 1 commit into
Oxygen56 wants to merge 1 commit into
Conversation
fetchWithTimeout was not cleaning up the abort event listener on successful completion, preventing Deno process exit. Fixes openai#1811 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the abort event listener in fetchWithTimeout on successful completion to prevent Deno process exit hang.
Problem
fetchWithTimeout adds an abort event listener on the caller's AbortSignal to forward abort events to the internal controller. On successful completion (response received before timeout), the timeout is cleared via clearTimeout, but the abort event listener is never removed.
In Deno, AbortSignal.timeout() refs the underlying timer when it has event listeners. The orphaned listener keeps the timer ref'd for the full timeout duration, preventing the process from exiting.
Fix
Add signal.removeEventListener('abort', abort) in the finally block alongside the existing clearTimeout(timeout). This ensures the event listener is always cleaned up on successful completion while preserving the existing { once: true } behavior for the abort path.
Testing
Fixes #1811