Skip to content

fix: keep adversarial review focus text out of option parsing#378

Open
kiwigitops wants to merge 2 commits into
openai:mainfrom
kiwigitops:fix-adversarial-review-focus-args
Open

fix: keep adversarial review focus text out of option parsing#378
kiwigitops wants to merge 2 commits into
openai:mainfrom
kiwigitops:fix-adversarial-review-focus-args

Conversation

@kiwigitops

@kiwigitops kiwigitops commented Jun 17, 2026

Copy link
Copy Markdown

Summary

  • stop review option parsing once the first focus-text positional starts
  • keep leading flags like --base main parseable for review commands
  • add a parser regression test for focus text containing --model

Closes #333.

Tests

  • node --test tests/args.test.mjs tests/commands.test.mjs
  • npx tsc -p tsconfig.app-server.json --pretty false

@kiwigitops kiwigitops requested a review from a team June 17, 2026 09:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de6ceddbf2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/codex/scripts/lib/args.mjs

Copy link
Copy Markdown
Author

Quick follow-up here. I fixed the dashed-positional case from review and added coverage for it. Happy to adjust the parser behavior further if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus text in adversarial-review is re-tokenized; --FLAG VALUE substrings leak into CLI args

1 participant