build: make pre-seed a default feature#1197
Merged
Merged
Conversation
pre-seed deps (aws-sdk-s3, flate2, tar) are already compiled for other default features. No reason to gate it — it's a core boot-time capability.
chaodu-agent
force-pushed
the
fix/enable-pre-seed-unified
branch
from
b72d759 to
98e417d
Compare
chaodu-agent
changed the title
pahud
approved these changes
Jun 25, 2026
thepagent
approved these changes
Jun 25, 2026
5 tasks
thepagent
pushed a commit
that referenced
this pull request
Jun 27, 2026
* fix(ambient): bypass discord-level bot gating for ambient buffer Bot messages in ambient-configured channels/threads were incorrectly blocked by the discord-level bot message gating (allow_bot_messages mode + trusted_bot_ids) before reaching the ambient routing logic. This caused ambient mode to never observe other bots' messages even when [ambient.discord].allow_bot_messages = true, because the discord-level gate runs first and returns early for non-@mention bot messages. Fix: Move thread detection before bot gating and add an ambient early-route that lets non-mention bot messages bypass discord-level bot gating entirely. The ambient-level allow_bot_messages config remains the sole gatekeeper for bot messages entering the ambient buffer. Flow after fix: 1. Thread detection (moved up) 2. Ambient context check (moved up) 3. Bot msg + ambient context + no mention → ambient buffer (NEW) 4. Bot message gating (unchanged, but ambient msgs never reach here) 5. Normal ambient routing (handles human msgs + bot @mentions) Closes #1197 * add debug tracing to ambient early-route paths Adds tracing::debug logs for both the buffered and rejected paths in the ambient early-route block, making it easier to diagnose ambient bot message routing issues. * perf: early-gate bot msgs when ambient is disabled Avoid unnecessary to_channel() API calls for non-mention bot messages when ambient mode is not configured. Previously these would have been rejected at bot gating without the extra async call; moving thread detection up should not regress that path. When ambient is None and allow_bot_messages is Off or Mentions, non- mention bot messages return immediately without hitting to_channel(). When allow_bot_messages is All, thread detection is still needed for normal dispatch, so we fall through. --------- Co-authored-by: 超渡法師 <超渡法師@openab.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
pre-seeda default feature instead of opt-in. Its deps (aws-sdk-s3,flate2,tar) are already compiled for other default features (config-s3,secrets-aws). No reason to gate a core boot-time capability behind a feature flag.[hooks.pre_seed]now works in all builds — standard and unified — without extra flags.