Skip to content

WEB-657: Working Capital loan delinquency pause resume#3695

Open
alberto-art3ch wants to merge 1 commit into
openMF:devfrom
alberto-art3ch:WEB-657/working-capital-loan-delinquency-pause-resume
Open

WEB-657: Working Capital loan delinquency pause resume#3695
alberto-art3ch wants to merge 1 commit into
openMF:devfrom
alberto-art3ch:WEB-657/working-capital-loan-delinquency-pause-resume

Conversation

@alberto-art3ch

@alberto-art3ch alberto-art3ch commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Description

User should be able to resume the active paused Delinquency from the UI

Related issues and discussion

#{Issue Number}

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • Bug Fixes
    • Improved the visibility of the resume action in the Loan Delinquency Actions table so it now appears appropriately for supported loan types.
    • Made action button behavior more consistent across product variants.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "pre_merge_checks"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 92bee2c2-b6f9-4cd4-9dd8-9cbc5aed4c31

📥 Commits

Reviewing files that changed from the base of the PR and between 32a2bda and 74693bd.

📒 Files selected for processing (1)
  • src/app/loans/loans-view/loan-delinquency-tags-tab/loan-delinquency-tags-tab.component.html

Walkthrough

In the loan delinquency tags tab template, the resume (play) button condition is refactored: the outer guard becomes isCurrentAndPauseAction(item) with two inner branches rendering separate buttons for loanProductService.isLoanProduct and loanProductService.isWorkingCapital, each with its own permission string and tooltip.

Changes

Resume Button Refactor

Layer / File(s) Summary
Resume button conditional branches
src/app/loans/loans-view/loan-delinquency-tags-tab/loan-delinquency-tags-tab.component.html
Outer guard changed to isCurrentAndPauseAction(item) with two inner *ngIf branches rendering the play button for loan-product and working-capital product types respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding working capital loan delinquency pause/resume UI support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant