Skip to content

Deprecate opentracing shim public API#8373

Open
ADITYA-CODE-SOURCE wants to merge 9 commits into
open-telemetry:mainfrom
ADITYA-CODE-SOURCE:issue-8323-deprecate-opentracing-shim
Open

Deprecate opentracing shim public API#8373
ADITYA-CODE-SOURCE wants to merge 9 commits into
open-telemetry:mainfrom
ADITYA-CODE-SOURCE:issue-8323-deprecate-opentracing-shim

Conversation

@ADITYA-CODE-SOURCE
Copy link
Copy Markdown
Contributor

Deprecate the public opentracing-shim entrypoints and update the module documentation in line with the OpenTelemetry specification guidance on OpenTracing compatibility.

This keeps behavior unchanged and limits the scope to deprecation annotations and docs for the legacy shim surface.

Fixes #8323

@ADITYA-CODE-SOURCE ADITYA-CODE-SOURCE requested a review from a team as a code owner May 6, 2026 04:24
@otelbot otelbot Bot added the api-change Changes to public API surface area label May 6, 2026
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented May 6, 2026

⚠️ API changes detected — additional maintainer review required

@jack-berg @jkwatson

This PR modifies the public API surface area of the following module(s):

  • opentelemetry-opentracing-shim

Please review the changes in docs/apidiffs/current_vs_latest/ carefully before approving.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (389ddb7) to head (54bd83f).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8373   +/-   ##
=========================================
  Coverage     90.88%   90.88%           
  Complexity     7985     7985           
=========================================
  Files           898      898           
  Lines         24107    24107           
  Branches       2406     2406           
=========================================
  Hits          21909    21909           
  Misses         1455     1455           
  Partials        743      743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge latest main, resolve conflicts, revert the unrelated graalvm configuration cache changes and I'll get this merged. Thanks!

notCompatibleWithConfigurationCache(
"GraalVM native test agent options are not serializable for this task.",
)
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert unrelated changes

@ADITYA-CODE-SOURCE
Copy link
Copy Markdown
Contributor Author

Merged latest main, resolved the conflicts, reverted the unrelated graal-incubating configuration-cache change, and updated the opentracing-shim apidiff against the current baseline. The branch has been pushed and checks are rerunning now.

@ADITYA-CODE-SOURCE
Copy link
Copy Markdown
Contributor Author

@jack-berg The remaining windows-latest, 8 failure is the same :integration-tests:graal-incubating:test configuration-cache issue and appears unrelated to the opentracing-shim change. I kept this PR focused and reverted the Graal workaround as requested. If helpful, I can follow up separately for that CI issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to public API surface area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate opentracing-shim

2 participants