[dynamic control] add initializing from declarative config#2881
Open
jackshirazi wants to merge 2 commits into
Open
[dynamic control] add initializing from declarative config#2881jackshirazi wants to merge 2 commits into
jackshirazi wants to merge 2 commits into
Conversation
Contributor
Author
|
@jack-berg I mentioned a while back that the documentation for this type of declarative config addition was minimal, so would love for you to review the implementation here. |
12 tasks
LikeTheSalad
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Sorry for the change set being a little larger than normal, but I thought it was better to combine all the declarative config support changes together, rather than adding them piecemeal. I think it may be easier to understand the whole than the parts
This contains
DeclarativeConfigurationCustomizerProviderthat reads top-leveltelemetry_policy/developmentfrom declarative config and routes it intoPolicyInitComponentProviderfortelemetry_policy/developmentto add the delagating sampler - initially for the rate sampling policy, but will later make more generic (includes a TODO for that)Existing Issue(s):
part of #2868
Testing:
Unit tests added, plus a manual end-to-end test using declarative config was performed
Documentation:
TBD see #2868
Outstanding items:
see #2868