Skip to content

[dynamic control] add initializing from declarative config#2881

Open
jackshirazi wants to merge 2 commits into
open-telemetry:mainfrom
jackshirazi:policy-phase2-02
Open

[dynamic control] add initializing from declarative config#2881
jackshirazi wants to merge 2 commits into
open-telemetry:mainfrom
jackshirazi:policy-phase2-02

Conversation

@jackshirazi
Copy link
Copy Markdown
Contributor

Description:

Sorry for the change set being a little larger than normal, but I thought it was better to combine all the declarative config support changes together, rather than adding them piecemeal. I think it may be easier to understand the whole than the parts

This contains

  • a DeclarativeConfigurationCustomizerProvider that reads top-level telemetry_policy/development from declarative config and routes it into PolicyInit
  • a declarative ComponentProvider for telemetry_policy/development to add the delagating sampler - initially for the rate sampling policy, but will later make more generic (includes a TODO for that)
  • Changes to PolicyInit to support the declarative config and also make it a one-shot execution so that a later/repeated/accidental auto-config pass does not accidentally re-use stale declarative config

Existing Issue(s):

part of #2868

Testing:

Unit tests added, plus a manual end-to-end test using declarative config was performed

Documentation:

TBD see #2868

Outstanding items:

see #2868

Copilot AI review requested due to automatic review settings May 27, 2026 23:00
@jackshirazi jackshirazi requested a review from a team as a code owner May 27, 2026 23:00
@github-actions github-actions Bot requested a review from LikeTheSalad May 27, 2026 23:01
@jackshirazi jackshirazi requested review from jack-berg and removed request for LikeTheSalad May 27, 2026 23:01
@github-actions github-actions Bot requested a review from LikeTheSalad May 27, 2026 23:03
@jackshirazi
Copy link
Copy Markdown
Contributor Author

@jack-berg I mentioned a while back that the documentation for this type of declarative config addition was minimal, so would love for you to review the implementation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants