[awsxray] Prevent regex on hot path#2879
Open
jaydeluca wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Small performance fixes in the AWS X-Ray sampler: replaces new Random() with ThreadLocalRandom for client ID generation, and pre-compiles anomaly-condition error code regexes once when the adaptive sampling config is applied rather than recompiling them on every span.
Changes:
- Use
ThreadLocalRandom.current()instead of allocating a newRandompergenerateClientId()call. - Pre-compile a
List<Pattern>of error code regexes alongside the adaptive sampling config, and switch the anomaly check loop to index-based iteration so the compiledPatternaligns with eachAnomalyConditions. - Reuse the cached compiled patterns in
isAnomalyinstead of callingString.matches(regex)per span.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/AwsXrayRemoteSampler.java | Drops java.util.Random import and uses ThreadLocalRandom in generateClientId(). |
| aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/XrayRulesSampler.java | Adds errorCodePatterns field populated via new compileErrorCodePatterns helper at construction and when the adaptive sampling config is set; uses pre-compiled Pattern in isAnomaly. |
jack-berg
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Small fixes
Random()