Add new tests - python#79
Open
angelrti wants to merge 36 commits into
Open
Conversation
… test_size_receivers that relies on the size of the samples, less error prone
…ly one from its group of samples
… unsupported tests
…so changed ordered access check function
…est_order to accept instances
… uses the passed tests instead of supported tests
Add HDDS to generate_xlsx_report.py
MiguelCompany
requested changes
May 25, 2026
Contributor
MiguelCompany
left a comment
MiguelCompany
left a comment
There was a problem hiding this comment.
Would be nice if you could rebase so we can better review the changes
disganaitis
requested changes
May 25, 2026
| 'apps' : ['-P -t Square --num-iterations 200 --num-instances 4', | ||
| '-S -t Square'], | ||
| 'expected_codes' : [ReturnCode.OK, ReturnCode.OK], | ||
| 'check_function' : tsf.test_unregistering_w_instances, |
Contributor
There was a problem hiding this comment.
DDS 1.4 Page 101, pdf page 113, WRITER_DATA_LIFECYCLE QoS, Values autodispose_unregistered_instances
Controls whether a DataWriter will automatically dispose instances each time they are unregistered. The setting autodispose_unregistered_instances = TRUE indicates that unregistered instances will also be considered disposed. By default, TRUE.
Therefore the default behavior should check for disposed instances.
Suggested change
| 'check_function' : tsf.test_unregistering_w_instances, | |
| 'check_function' : tsf.test_disposing_w_instances, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs several new tests with the options that are already in master. Please upload a new executable, otherwise tests will fail or will show "not supported".
I've created the draft release https://github.com/omg-dds/dds-rtps/releases/tag/untagged-4184f9579b03abc94c64 for the new executables