Use io.Copy for SSH uploads#805
Merged
Merged
Conversation
Member
|
This is very nice both in terms of functionality and also as a simplification 🎩 |
Member
|
I'll release this once #784 is ready, which I hope is rather soon. If this not being released is blocking you lmk and I can cut a release anyways. |
Contributor
Author
|
I have temporarily raised memory limits to prevent OOMs. That's going to hold nicely until a regular release; no need for an extra one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #804
Tested with a ~300 MiB archive uploaded to an SSH backend by a container with a 64 MiB memory limit. Memory usage hovered around 35 MiB for the duration of the upload