[IMP] Marketing Card: campaign updates#18079
Open
stepperpig wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
Contributor
Author
|
Hi @huisit, got a PR ready for your review when you have a moment - thank you! |
huisit
reviewed
May 26, 2026
Contributor
huisit
left a comment
huisit
left a comment
There was a problem hiding this comment.
@stepperpig the new copy look good! Just a couple questions about the functionality, based on runbot:
- Translations: The second
noteadmonition mentions an EN button for translations, but I can't get it to show up. Are there any conditions for it to appear? - Card language: I'm only seeing English in the list here, is there a way to get other languages to show up here?
Contributor
Author
|
Ah, thanks for catching that, @huisit - the |
huisit
approved these changes
May 26, 2026
Contributor
huisit
left a comment
huisit
left a comment
There was a problem hiding this comment.
@stepperpig gotcha, in that case this should be fine to merge! I've approved, but a few non-urgent suggestions if you have the time:
- Line 93: link to that article about adding languages
- Line 101: update/remove pop-up instructions, I'm seeing a window with ALL of the available languages. Not sure if the user is meant to manually edit translations:
- Line 168: update screenshot in Configure mailing to include Card Language field referenced in 173
stepperpig
force-pushed
the
saas-19.3-marketing-card-updates-kaili
branch
from
6c5ff5e to
197551d
Compare
stepperpig
force-pushed
the
saas-19.3-marketing-card-updates-kaili
branch
from
197551d to
75844b7
Compare
Contributor
Author
|
Hi @Felicious this is ready for a final check, thank you! |
Felicious
approved these changes
May 29, 2026
robodoo
pushed a commit
that referenced
this pull request
May 29, 2026
closes #18079 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 29, 2026
closes #18079 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 29, 2026
closes #18079 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update doc for 19.3 Marketing Card updates. Main changes outlined in the R&D task and relevant PRs below include multi-language support for static fields and card generation, and also default target URLs for linking to event pages.
R&D Task
PR
Changelog
Version Scope
This 19.3 PR should be FWP up to master.