Skip to content

fix(git-node): handle multi-line trailers#1062

Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95:multi-line-trailers
Open

fix(git-node): handle multi-line trailers#1062
aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95:multi-line-trailers

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 15, 2026

The current code assumes trailers will always be single-line, having a multi-line trailer currently results in non-sense output. This PR switch to relying on calling git interpret-trailers multiple times to filter out the trailers consistently.

Fixes: nodejs/node#62577 (comment)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.78%. Comparing base (f0587fa) to head (1e929e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
+ Coverage   71.74%   71.78%   +0.03%     
==========================================
  Files          41       41              
  Lines        5878     5886       +8     
==========================================
+ Hits         4217     4225       +8     
  Misses       1661     1661              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requiring Signed-off-by moving forward

1 participant