Add explicit collaborator list into README.md as per GOVERNANCE.md#2455
Add explicit collaborator list into README.md as per GOVERNANCE.md#2455sxa wants to merge 2 commits intonodejs:mainfrom
Conversation
|
See PR #2456 to fix the markdown-link-check issues that suddenly started to appear today in several workflow runs https://github.com/nodejs/docker-node/actions/workflows/markdown-link-check.yml |
|
It would probably make sense to add a workflow similar to https://github.com/nodejs/node/blob/HEAD/tools/lint-readme-lists.mjs / https://github.com/nodejs/node/blob/dd3fe4997bc2a50cfb06282ba53d3af6877c907e/.github/workflows/linters.yml#L257-L286 to help keep the README in sync with the actual team |
Signed-off-by: Stewart X Addison <sxa@ibm.com>
|
Above force was to rebase on top fo the linker fixes.
Yep, we could look at that later but for the purposes of this PR (Which is ultimately to assist with giving Mike collaborator access in the repository) let's not expand the scope. The issue we've had with this repository is not having many people active to be able to do fixes etc. |
README.md
Outdated
| Additional collaborators are managed via the | ||
| [@nodejs/docker team](https://github.com/orgs/nodejs/teams/docker). |
There was a problem hiding this comment.
I suggest to have the list of names appear before the comment about how to add names.
There was a problem hiding this comment.
I don't mind it being before, but I've made that change and also removed "Additional" since "managed" implies addition and removal.
| Additional collaborators are managed via the | ||
| [@nodejs/docker team](https://github.com/orgs/nodejs/teams/docker). | ||
|
|
||
| - Hugues Malphettes ([hmalphettes](https://github.com/hmalphettes)) |
There was a problem hiding this comment.
This GitHub user was last active in 2024
There was a problem hiding this comment.
Fair comment however since they are currently in the list of people with access we should list them and subsequently update it if required.
There was a problem hiding this comment.
I agree that it's cleaner to make that a separate PR (unless of course they themselves respond here, which I wouldn't expect, given their inactivity).
There was a problem hiding this comment.
I expect we can reasonably have a separate subsequent PR to move them to emeritus and consider a lack of response to be a sign that it's ok. It can always be reversed if needed. Having the list in here will give us a process for doing exactly that.
|
According to the GOVERNANCE document, it is the responsibility of Maintainers to manage and approve membership, so at least one of the following would need to approve this PR actively:
Since the list of Collaborators is now being published, it would also make sense for Collaborators to confirm their agreement:
|
Signed-off-by: Stewart X Addison <sxa@ibm.com>
MikeMcC399
left a comment
There was a problem hiding this comment.
Thanks for responding to comments!
Adding copy of the collaborator list into here in order to allow Pull Requests to be used for the process as per the governance doc
Ref: discussion in #2448
Description
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist