Skip to content

Add explicit collaborator list into README.md as per GOVERNANCE.md#2455

Open
sxa wants to merge 2 commits intonodejs:mainfrom
sxa:collaborator_list
Open

Add explicit collaborator list into README.md as per GOVERNANCE.md#2455
sxa wants to merge 2 commits intonodejs:mainfrom
sxa:collaborator_list

Conversation

@sxa
Copy link
Copy Markdown
Member

@sxa sxa commented Apr 13, 2026

Adding copy of the collaborator list into here in order to allow Pull Requests to be used for the process as per the governance doc

Ref: discussion in #2448

Description

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@sxa sxa force-pushed the collaborator_list branch from 8d61b1a to 5c7b505 Compare April 13, 2026 14:43
@MikeMcC399
Copy link
Copy Markdown
Contributor

See PR #2456 to fix the markdown-link-check issues that suddenly started to appear today in several workflow runs https://github.com/nodejs/docker-node/actions/workflows/markdown-link-check.yml

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Apr 13, 2026

It would probably make sense to add a workflow similar to https://github.com/nodejs/node/blob/HEAD/tools/lint-readme-lists.mjs / https://github.com/nodejs/node/blob/dd3fe4997bc2a50cfb06282ba53d3af6877c907e/.github/workflows/linters.yml#L257-L286 to help keep the README in sync with the actual team

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa sxa force-pushed the collaborator_list branch from 5c7b505 to 61a6612 Compare April 13, 2026 18:09
@sxa
Copy link
Copy Markdown
Member Author

sxa commented Apr 13, 2026

Above force was to rebase on top fo the linker fixes.

It would probably make sense to add a workflow simila to https://github.com/nodejs/node/blob/HEAD/tools/lint-readme-lists.mjs / https://github.com/nodejs/node/blob/dd3fe4997bc2a50cfb06282ba53d3af6877c907e/.github/workflows/linters.yml#L257-L286 to help keep the README in sync with the actual team

Yep, we could look at that later but for the purposes of this PR (Which is ultimately to assist with giving Mike collaborator access in the repository) let's not expand the scope. The issue we've had with this repository is not having many people active to be able to do fixes etc.

README.md Outdated
Comment on lines 297 to 298
Additional collaborators are managed via the
[@nodejs/docker team](https://github.com/orgs/nodejs/teams/docker).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to have the list of names appear before the comment about how to add names.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind it being before, but I've made that change and also removed "Additional" since "managed" implies addition and removal.

Additional collaborators are managed via the
[@nodejs/docker team](https://github.com/orgs/nodejs/teams/docker).

- Hugues Malphettes ([hmalphettes](https://github.com/hmalphettes))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This GitHub user was last active in 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair comment however since they are currently in the list of people with access we should list them and subsequently update it if required.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's cleaner to make that a separate PR (unless of course they themselves respond here, which I wouldn't expect, given their inactivity).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect we can reasonably have a separate subsequent PR to move them to emeritus and consider a lack of response to be a sign that it's ok. It can always be reversed if needed. Having the list in here will give us a process for doing exactly that.

@MikeMcC399
Copy link
Copy Markdown
Contributor

According to the GOVERNANCE document, it is the responsibility of Maintainers to manage and approve membership, so at least one of the following would need to approve this PR actively:

Since the list of Collaborators is now being published, it would also make sense for Collaborators to confirm their agreement:

MikeMcC399

This comment was marked as resolved.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding to comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants