add optional logout URL step to self-hosted IdP setup guides#775
add optional logout URL step to self-hosted IdP setup guides#775TechHutTV wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThis pull request adds optional logout redirect URI configuration instructions to 12 identity provider setup guides. Self-hosted providers (ADFS, Authentik, Generic OIDC, Keycloak) and managed services (Auth0, Okta, Zitadel, etc.) receive instructions to register NetBird's logout callback URL. Duo and Google Workspace documentation clarifies these platforms lack logout redirect support. ChangesLogout Redirect URI Configuration Guidance
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/pages/selfhosted/identity-providers/adfs.mdxOops! Something went wrong! :( ESLint: 9.39.4 TypeError: Converting circular structure to JSON src/pages/selfhosted/identity-providers/authentik.mdxOops! Something went wrong! :( ESLint: 9.39.4 TypeError: Converting circular structure to JSON src/pages/selfhosted/identity-providers/generic-oidc.mdxOops! Something went wrong! :( ESLint: 9.39.4 TypeError: Converting circular structure to JSON
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds an optional step to the self-hosted Identity Provider setup guides showing how to register NetBird's logout callback URL (
https://netbird.example.com/oauth2/logout/callback) so that signing out of NetBird redirects back cleanly through the IdP. The step is placed inline at the point where each guide configures the OIDC redirect URI, and names the correct field for each provider (the field label differs per IdP). Providers that don't expose a logout/sign-out redirect field get a short clarifying note instead of a step.advanced/*guides are intentionally untouched.Description
What changed
Each guide gets the logout URL added as an optional in-flow step next to the existing redirect-URI step, using the same domain placeholder convention already used in that file (
netbird.example.com,<NETBIRD_FQDN>for ADFS,<your-netbird-domain>for JumpCloud / Generic OIDC).The logout URL is constant —
…/oauth2/logout/callback— but where it goes differs per provider:post_logout_redirect_uriagainst registered redirect URIs)-RedirectUriarray (same reason)Providers without a logout field
Duo (generic OIDC relying party exposes only Sign-In Redirect URLs) and Google Workspace (OAuth 2.0 client has only Authorized redirect URIs) have no logout/sign-out redirect field. Rather than document a step against a field that doesn't exist, these two pages get a short
<Note>stating no logout URL needs to be configured.Note
The logout mechanism was inferred from the
/oauth2/logout/callbackpath (treated as a post-logout redirect the IdP returns the browser to).Files changed
12 files under
src/pages/selfhosted/identity-providers/(adfs, authentik, generic-oidc, keycloak, pocketid, zitadel, and managed/{auth0, duo, google-workspace, jumpcloud, microsoft-entra-id, okta}).Summary by CodeRabbit