Skip to content

Release cleanup#759

Merged
ppenna merged 2 commits into
nanvix/v3.12.3from
fix/741/no-build-in-release
Jun 22, 2026
Merged

Release cleanup#759
ppenna merged 2 commits into
nanvix/v3.12.3from
fix/741/no-build-in-release

Conversation

@ada-x64

@ada-x64 ada-x64 commented Jun 19, 2026

Copy link
Copy Markdown
  • Stage release in build step
  • Build and stage to sane output locations
  • Removes orphaned ramfs item not present in default branch release

Closes #741

Copilot AI review requested due to automatic review settings June 19, 2026 21:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the Nanvix CPython release pipeline so that release artifacts are staged during the build step, and the release command only packages/validates already-built outputs (addressing Issue #741: “Do not build in def release()”).

Changes:

  • Move release staging work (lxml runtime staging, sysroot/buildroot staging, ramfs image generation) into ./z build.
  • Refactor packaging code to use stable staging directories (release_dir/sysroot-pkg and release_dir/buildroot-pkg) and tar them verbatim.
  • Extend sysroot trimming to also remove the python<version> binary from bin/.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.nanvix/z.py Updates build() to perform release staging/ramfs generation; keeps release() focused on packaging/verification only.
.nanvix/package.py Splits staging vs. tarball creation; introduces explicit staging directory helpers and verbatim tar logic.
.nanvix/config.py Adds python<version> to sysroot bin trimming patterns.
.nanvix/build.py Changes release install DESTDIR to release_dir/sysroot-pkg to match the new staging layout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .nanvix/build.py
Comment thread .nanvix/package.py
@ada-x64 ada-x64 marked this pull request as ready for review June 19, 2026 21:30
@ada-x64 ada-x64 requested review from Copilot and ppenna June 19, 2026 21:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread .nanvix/build.py
Comment thread .nanvix/package.py
Comment thread .nanvix/build.py
ada-x64 added 2 commits June 22, 2026 06:48
- Build and stage to sane output locations

Closes #741
@ppenna ppenna force-pushed the fix/741/no-build-in-release branch from 7464946 to ae60e5b Compare June 22, 2026 13:48
@ppenna ppenna merged commit c530aaf into nanvix/v3.12.3 Jun 22, 2026
15 checks passed
@ppenna ppenna deleted the fix/741/no-build-in-release branch June 22, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not build in def release()

3 participants