Release cleanup#759
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restructures the Nanvix CPython release pipeline so that release artifacts are staged during the build step, and the release command only packages/validates already-built outputs (addressing Issue #741: “Do not build in def release()”).
Changes:
- Move release staging work (lxml runtime staging, sysroot/buildroot staging, ramfs image generation) into
./z build. - Refactor packaging code to use stable staging directories (
release_dir/sysroot-pkgandrelease_dir/buildroot-pkg) and tar them verbatim. - Extend sysroot trimming to also remove the
python<version>binary frombin/.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .nanvix/z.py | Updates build() to perform release staging/ramfs generation; keeps release() focused on packaging/verification only. |
| .nanvix/package.py | Splits staging vs. tarball creation; introduces explicit staging directory helpers and verbatim tar logic. |
| .nanvix/config.py | Adds python<version> to sysroot bin trimming patterns. |
| .nanvix/build.py | Changes release install DESTDIR to release_dir/sysroot-pkg to match the new staging layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Build and stage to sane output locations Closes #741
7464946 to
ae60e5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #741