Skip to content

[build] Don't build in test#751

Merged
ppenna merged 1 commit into
nanvix/v3.12.3from
fix/740/build-out
Jun 19, 2026
Merged

[build] Don't build in test#751
ppenna merged 1 commit into
nanvix/v3.12.3from
fix/740/build-out

Conversation

@ada-x64

@ada-x64 ada-x64 commented Jun 17, 2026

Copy link
Copy Markdown
  • ./z build now clean builds both release and test output to .nanvix/out/{release,test}
  • _test.py() :: stage() now invoked at build time.
  • Removed redundant installation caches from _test.py()

Closes #740

Copilot AI review requested due to automatic review settings June 17, 2026 21:14

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings June 18, 2026 15:05
@ada-x64 ada-x64 force-pushed the fix/740/build-out branch from 5505468 to 113a3bc Compare June 18, 2026 15:05

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings June 18, 2026 17:24
@ada-x64 ada-x64 force-pushed the fix/740/build-out branch from 54b5acc to 295adf9 Compare June 18, 2026 17:24
@ada-x64 ada-x64 force-pushed the fix/740/build-out branch from 295adf9 to 186957a Compare June 18, 2026 17:26

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings June 18, 2026 18:38
@ada-x64 ada-x64 force-pushed the fix/740/build-out branch from 186957a to d52ed05 Compare June 18, 2026 18:38

This comment was marked as resolved.

@ada-x64 ada-x64 force-pushed the fix/740/build-out branch from d52ed05 to 2d5b276 Compare June 18, 2026 19:06
Copilot AI review requested due to automatic review settings June 18, 2026 20:28

This comment was marked as resolved.

@ada-x64 ada-x64 force-pushed the fix/740/build-out branch from 5b1ba0e to 75d0968 Compare June 18, 2026 20:39
Copilot AI review requested due to automatic review settings June 18, 2026 21:20
@ada-x64 ada-x64 force-pushed the fix/740/build-out branch from 527e82b to b016b8b Compare June 18, 2026 21:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread .nanvix/_test.py
Comment thread .nanvix/build.py
Comment on lines +145 to 150
if not preserve_nanvix_root:
for name in ("cache", "_benchmark_cache", "_ramfs_cache", "out"):
p = paths.nanvix_root() / name
if p.is_dir():
shutil.rmtree(p)
print(f"Removed .nanvix/{name}/")
- ./z build now clean builds both release and test output to .nanvix/out/{release,test}
- _test.py() :: stage() now invoked at build time.
- Removed redundant installation caches from _test.py()
- Reconfigure between builds, preserving release output.
- Update doc comments
Copilot AI review requested due to automatic review settings June 18, 2026 21:58
@ada-x64 ada-x64 force-pushed the fix/740/build-out branch from b016b8b to 4013747 Compare June 18, 2026 21:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread .nanvix/_test.py
Comment thread .nanvix/z.py
Comment on lines +210 to 213
# Two separate builds: first release -> out/release/, then test -> out/test/.
build_mod.clean(preserve_nanvix_root=False, preserve_cache=True)
args = self._make_args(release=True)
build_mod.build(args)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ada-x64 ada-x64 marked this pull request as ready for review June 18, 2026 22:12
@ppenna ppenna self-assigned this Jun 19, 2026
@ada-x64 ada-x64 linked an issue Jun 19, 2026 that may be closed by this pull request
@ppenna ppenna changed the title Don't build in test. [build] Don't build in test Jun 19, 2026

@ppenna ppenna left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna merged commit 815c4ee into nanvix/v3.12.3 Jun 19, 2026
16 checks passed
@ppenna ppenna deleted the fix/740/build-out branch June 19, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build to release/ and test/, remove build from def test().

3 participants