Fix pre-existing trailing whitespace in Modules/_cffi_backend/#724
Open
esaurez wants to merge 1 commit into
Open
Fix pre-existing trailing whitespace in Modules/_cffi_backend/#724esaurez wants to merge 1 commit into
esaurez wants to merge 1 commit into
Conversation
Strips trailing whitespace from 5 third-party cffi-backend source files that have been failing the repo's pre-commit `trim trailing whitespace` hook for some time. The hook applies to all .c / .h files in the repository, but the cffi-backend sources predate the hook being enabled and were never fixed. Without this cleanup, every Nanvix-related PR fails the upstream Lint workflow regardless of its actual content. Pure mechanical change: 5 files / +8/-8, only trailing whitespace removed (no semantic edits). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strips trailing whitespace from 5 third-party
_cffi_backendsource files that have been failing the upstream cpythonlintworkflow'strim trailing whitespacepre-commit hook ever since they were added in commit68d3969("feat(nanvix): add _cffi_backend as built-in module").Pure mechanical cleanup: 5 files / +8/-8, no semantic edits.
Why
The
pre-commithook in.pre-commit-config.yamlapplies thetrailing-whitespacerule to everyc/inc/python/rstfile in the repo. The cffi 1.17.1 sources vendored in68d3969predate the hook being enforced and were never cleaned up. As a result, every PR fails the upstreamLintworkflow regardless of its actual content, which makes the green-check baseline meaningless for anything new.This PR establishes a clean baseline so the
Lintworkflow becomes a real signal again on follow-up work.What changed
5 files, all in
Modules/_cffi_backend/:_cffi_backend.c— 6 linescffi1_module.c— 1 linelib_obj.c— 1 linemisc_thread_common.h— 2 linesmisc_win32.h— 1 lineVerified by running
pre-commit run --all-fileslocally; after this change thetrim trailing whitespacehook passes and the rest of the workflow is unaffected.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com