Skip to content

[DockWindow V2] Added missing method#86

Merged
Eism merged 1 commit into
musescore:mainfrom
Eism:dwv2_open_pages_fix
Jun 15, 2026
Merged

[DockWindow V2] Added missing method#86
Eism merged 1 commit into
musescore:mainfrom
Eism:dwv2_open_pages_fix

Conversation

@Eism

@Eism Eism commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Port of #32

@Eism Eism requested review from RomanPudashkin and ajuncosa June 15, 2026 11:04
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a09ecf2d-649f-421e-8f12-424b148ad82a

📥 Commits

Reviewing files that changed from the base of the PR and between 2f1e8a2 and a8c3318.

📒 Files selected for processing (2)
  • framework/dockwindow_v2/qml/Muse/Dock/dockwindow.cpp
  • framework/dockwindow_v2/qml/Muse/Dock/dockwindow.h

📝 Walkthrough

Walkthrough

A new Q_INVOKABLE public method openPage(const QString& uri) is added to the DockWindow class. The header declares the method alongside a comment distinguishing it from loadPage(), which is reserved for internal use by InteractiveProvider. The implementation in the source file converts the URI to std::string and forwards it to interactive()->open().

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is severely incomplete. It only mentions this is a port of PR #32 but lacks required sections like issue reference, motivation, testing details, and CLA confirmation. Fill in the description template with issue reference, detailed motivation for the changes, completion of the contribution checklist, and testing verification.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and generic. It does not clearly describe what the missing method does or its purpose, only stating that a method was added. Replace with a more specific title, such as '[DockWindow V2] Add openPage() method to ensure proper interactive flow initialization' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Eism Eism merged commit bbb399b into musescore:main Jun 15, 2026
3 checks passed
@Eism Eism deleted the dwv2_open_pages_fix branch June 15, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants