PopupView: fix top and bottom overflow

[RiccardoCampo]

Resolves: audacity/audacity#10660

Fix PopupView top and bottom overflow. Lower the popup if it's position overflows the window's height (and viceversa for bottom).

Previous attempts:

• fix(ui): make track ruler customize popup scrollable audacity/audacity#10871
• fix(track-ruler): make customize popup scrollable and prevent content… audacity/audacity#10875

• I signed the CLA as camporcr:
• The title of the PR describes the problem it addresses.
• Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
• The code in the PR follows the coding rules.
• I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
• The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
• No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
• There are no unnecessary changes.
• I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 87ef0ba6-8fef-4cce-9184-80028a8d0180

📥 Commits

Reviewing files that changed from the base of the PR and between 5e1045b and 831e6cb.

📒 Files selected for processing (1)

• framework/uicomponents/qml/Muse/UiComponents/popupview.cpp

---

📝 Walkthrough

Walkthrough

This PR enhances popup positioning in the Muse Framework's UI components. The PopupView::updateGeometry() method now includes explicit vertical overflow handling: it checks if the popup extends below the anchor rectangle's bottom and adjusts the position upward if needed, and checks if the popup extends above the anchor's top and adjusts downward accordingly. This complements the existing horizontal overflow corrections already present in the function.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: handling top and bottom overflow in PopupView positioning logic.
Description check	✅ Passed	The PR description is mostly complete with issue link, problem description, previous attempts, and all checklist items addressed.
Linked Issues check	✅ Passed	The code changes directly address issue #10660 by implementing vertical overflow detection and adjustment logic to keep popups visible within window bounds.
Out of Scope Changes check	✅ Passed	All changes are scoped to PopupView::updateGeometry() vertical overflow handling, directly addressing the linked issue requirement without extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}