Skip to content

Fix #25317: Fix fermata application to barlines in range selections#33795

Open
pyonpyoco wants to merge 1 commit into
musescore:mainfrom
pyonpyoco:range-fermata-barlines
Open

Fix #25317: Fix fermata application to barlines in range selections#33795
pyonpyoco wants to merge 1 commit into
musescore:mainfrom
pyonpyoco:range-fermata-barlines

Conversation

@pyonpyoco

Copy link
Copy Markdown
Contributor

Resolves: #25317

When applying fermatas to a range selection, barlines were also treated as targets. This change handles fermatas like articulations in range selections, so fermatas are not added to barlines unless the barline is explicitly selected.

2026-06-12.203834.mp4
  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7968c64a-76f9-406e-842b-069c02e7084f

📥 Commits

Reviewing files that changed from the base of the PR and between 56d690c and 11e6a87.

📒 Files selected for processing (1)
  • src/notation/internal/notationinteraction.cpp

📝 Walkthrough

Walkthrough

This PR refines palette element application logic in NotationInteraction::applyPaletteElementToRange. The barline-skipping condition is updated to uniformly exclude barlines from receiving any palette element unless that element is specifically an articulation or fermata. This replaces the previous articulation-family-only check, treating both articulation and fermata types with consistent logic.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: fixing fermata application to barlines in range selections, directly matching the primary objective of the PR.
Description check ✅ Passed The description includes the issue reference, clear motivation, completed checklist items, and supporting assets; however, no unit test was created despite applicability.
Linked Issues check ✅ Passed The code changes directly address issue #25317 by preventing fermatas from being applied to barlines in range selections unless explicitly selected, matching the expected behavior.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing fermata application logic in range selections; no unrelated modifications are present in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a fermata to a measure selection causes extra one to be added to every barline on every staff

4 participants