Fix #181 #183 memory corruption when unpacking unknown enum or repacking enum#184
Open
cracksalad wants to merge 1 commit intomsgpack:masterfrom
Open
Fix #181 #183 memory corruption when unpacking unknown enum or repacking enum#184cracksalad wants to merge 1 commit intomsgpack:masterfrom
cracksalad wants to merge 1 commit intomsgpack:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 73.88% 68.51% -5.37%
==========================================
Files 6 7 +1
Lines 1191 1350 +159
Branches 0 247 +247
==========================================
+ Hits 880 925 +45
+ Misses 311 310 -1
- Partials 0 115 +115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
34b5451 to
5bded50
Compare
…enum or repacking enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one unpacks a serialized enum value and...
required nor autoloadable) ortest\MyType) is not an enum but a normal class or...there is no warning or error thrown but one would experience memory corruption instead. I am talking about variables having values which are not allowed by their types and something like that - really scary.
Fixes #181 and probably #183 as well.
With regards to the repacking issue, we need to add to the ref count for some reason when unpacking an enum value. That is why I replaced
ZVAL_OBJwithZVAL_OBJ_COPYsince the difference is exactly that:Excerpt from php/php-src/Zend/zend_types.h#L1138