docs: fix branch-protection accuracy; tighten cluster-safety test#50
Conversation
- auto-release.md: required conversation resolution is OFF (an auto-reviewer's unresolved threads would otherwise wedge the hands-off bump loop); include the required_pull_request_reviews sub-fields in the revert snippet so the API accepts the partial object. - redis.test.ts: assert the cluster-safety test's del calls hit exactly the expected single keys (k1 then k2), not just "some del happened". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the docs/auto-release.md documentation to reflect that 'Required conversation resolution' is disabled on the main branch to prevent automated review comments from blocking auto-merges, and updates the example API command accordingly. Additionally, it refines a Redis cluster safety test in redis.test.ts to assert specific deleted keys instead of a generic deletion check. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
What
Two loose-end cleanups after the release-automation work (#46–#49) landed:
docs/auto-release.mdaccuracy — the branch-protection section claimedrequired conversation resolution stays on. It's off, and deliberately so:
the
gemini-code-assistauto-reviewer leaves review threads on every PR, andwith conversation resolution required those unresolved threads would block
auto-merge — wedging the hands-off bump loop on every release. The e2e status
checks are the real gate. Also fixed the revert snippet to include the
required_pull_request_reviewssub-fields (the GitHub API rejects a partialobject).
redis.test.tscluster-safety test — applies gemini's suggestion fromtest(redis): lock in cluster-safe single-key invariant #49: assert the
delcalls target exactly the expected single keys(
nextjs:data-cache:k1thenk2) instead of just "some del happened". Makesthe single-key invariant assertion exact rather than vacuous-resistant only.
Checks
pnpm lint✅ ·pnpm typecheck✅ · unit tests ✅ (123 passed)🤖 Generated with Claude Code