Add year selector to chart in profile page, improve light theme#4205
Merged
Conversation
The default remains last 12 months, but it's now possible to select previous years. Fixes mozilla#2619
mathjazz
reviewed
Jun 9, 2026
mathjazz
left a comment
mathjazz
left a comment
Collaborator
There was a problem hiding this comment.
Works nicely! 👏
- Left some design comments on Slack (which seem applied in the screenshots only).
- Please align the top of the Last year button with the top of the square in the first row of the chart.
- Could you show the entire chart when the unfinished year (2026) is selected?
Collaborator
Author
I squashed the changes in the first commit, but forgot to force push. I'll add them as a separate commit at this point, together with the other changes. |
- Use gray background instead of green, right align labels - Show full chart for current year - Align Last year selector with chart's top
Collaborator
Author
|
Added separate commit with the changes, also had to merge |
mathjazz
approved these changes
Jun 9, 2026
mathjazz
left a comment
mathjazz
left a comment
Collaborator
There was a problem hiding this comment.
Great work! Left a suggestion for minor styling consistency improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default remains last 12 months, but it's now possible to select previous years.
Also noticed a bug with the chart and theme switching while testing. Took the opportunity to change the colors to be a little lighter.
Fixes #2619
Charts with year selector
Chart with current light mode