Bug 2040030 - Increase pending pings limitations to better support long network outages#3462
Merged
Conversation
travis79
force-pushed
the
Bug2040030
branch
2 times, most recently
from
ad1d196 to
e6149f1
Compare
badboy
approved these changes
May 26, 2026
Member
badboy
left a comment
badboy
left a comment
There was a problem hiding this comment.
r+wc. Comments inline.
If you had asked me like a week ago I could have sworn we had already exposed those limits as configuration options. But I guess we didn't.
…ng network outages This increases the pending pings limit from 250 to 500, and also increases the pending pings directory size limit from 10MB to 50MB. In order to make this more configurable to consuming apps, I've also exposed these as properties in the Configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases the pending pings limit from 250 to 500, and also increases the pending pings directory size limit from 10MB to 50MB. In order to make this more configurable to consuming apps, I've also exposed these as properties in the Configuration.