Skip to content

Include patch to skip bugs filed by creators with editbugs permissions in spambug model.#3376

Open
jpangas wants to merge 3 commits intomozilla:masterfrom
jpangas:eval_spambug
Open

Include patch to skip bugs filed by creators with editbugs permissions in spambug model.#3376
jpangas wants to merge 3 commits intomozilla:masterfrom
jpangas:eval_spambug

Conversation

@jpangas
Copy link
Copy Markdown
Contributor

@jpangas jpangas commented Mar 22, 2023

Reference Issues

Resolves #2787

Explained Changes:

This PR includes small changes that allow us to skip bugs filed by creators with editbugs permissions. It also includes a change that skips bugs filed by creators with the "@softvision" domain.

Any other comments?

The PR could not be tested on my side because I lack the necessary permissions. i.e. It returns an HTTPError when the request is made. It needs to be tested by someone with the right permissions.

@jpangas
Copy link
Copy Markdown
Contributor Author

jpangas commented Mar 22, 2023

Ping @suhaibmujahid and @marco-c

@suhaibmujahid
Copy link
Copy Markdown
Member

The PR could not be tested on my side because I lack the necessary permissions

Thank you, @jpangas. Unfortunately, I found out that I do not have permissions as well. Could you please work on another issue for now?

@jpangas
Copy link
Copy Markdown
Contributor Author

jpangas commented Mar 23, 2023

Sure! Thank you @suhaibmujahid, I am going to work on another in the mean time.

@jpangas jpangas marked this pull request as ready for review August 1, 2024 13:45
@jpangas
Copy link
Copy Markdown
Contributor Author

jpangas commented Aug 1, 2024

What had we concluded on this PR?

@marco-c
Copy link
Copy Markdown
Collaborator

marco-c commented Aug 1, 2024

@jpangas I can run it for you.

The PR is excluding these bugs both from the training set and from the evaluation set.
It would be nice to only exclude them from the evaluation set, and then test the two alternatives (with or without the bugs) in the training set.

@jpangas
Copy link
Copy Markdown
Contributor Author

jpangas commented Aug 9, 2024

@marco-c , after discussing with @suhaibmujahid, there is some refactoring he is working on which will make completion of this issue easier. We can wait and I will resume on this after.

@suhaibmujahid
Copy link
Copy Markdown
Member

@marco-c , after discussing with @suhaibmujahid, there is some refactoring he is working on which will make completion of this issue easier. We can wait and I will resume on this after.

I filed an issue for that: #4407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only evaluate spambug on bugs filed by people without "editbugs" permissions, then check if it's better to train on all or just non-editbugs

3 participants