Skip to content

update CheckConstraint to use condition kwarg over check#24866

Merged
eviljeff merged 1 commit into
mozilla:masterfrom
eviljeff:16012-check-constraint-use-condition
May 11, 2026
Merged

update CheckConstraint to use condition kwarg over check#24866
eviljeff merged 1 commit into
mozilla:masterfrom
eviljeff:16012-check-constraint-use-condition

Conversation

@eviljeff
Copy link
Copy Markdown
Member

@eviljeff eviljeff commented May 8, 2026

One of the items from mozilla/addons#16012

Description

CheckConstraint's check arg is deprecated in favour of a condition kwarg.

Context

It apparently will be removed in django6.0, so this is to get ahead of that deprecation, and to silence some of the warnings that clutter up logging

Testing

n/a

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff marked this pull request as ready for review May 8, 2026 12:41
@eviljeff eviljeff requested a review from diox May 8, 2026 12:41
@eviljeff eviljeff merged commit 8f98e40 into mozilla:master May 11, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants