Add static showcase deployment and GitHub Pages support#4
Add static showcase deployment and GitHub Pages support#4moritzbrantner wants to merge 1 commit into
Conversation
- Replace the old static-first shell with localized en/de routes - Add hotkeys, theme, consent, auth, upload, table, blog, and report flows - Update static/server providers, tests, and docs for the new app surface
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7683991758
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!event.altKey || event.ctrlKey || event.metaKey || event.shiftKey) { | ||
| return; | ||
| } | ||
|
|
||
| const entry = this.hotkeyService.findEntry(this.groups(), event.key); |
There was a problem hiding this comment.
This handler runs for every window:keydown event and currently processes Alt+<key> without checking whether the user is typing in an editable element. In forms (login/register/report/details textareas), pressing Alt-based character combinations or browser/menu shortcuts can trigger route navigation and lose in-progress input. Add an early return when the event target is input, textarea, select, or contenteditable before resolving hotkeys.
Useful? React with 👍 / 👎.
| .pipe(finalize(() => { | ||
| this.submitting.set(false); | ||
| this.form.enable(); | ||
| })) | ||
| .subscribe((result) => { |
There was a problem hiding this comment.
The login submit flow subscribes with only a success callback, so in API mode any HTTP/network failure from AuthRepository.login() propagates as an unhandled observable error and no user-facing error message is set. That leaves users without feedback on failed sign-in attempts. Add an error handler here (similar to the contact form flow) to set hasSubmissionError and a failure message.
Useful? React with 👍 / 👎.
1 participant
Summary
next-templatereference.Testing
npm run test:unitnpm run test:integrationnpm run test:e2enpm run buildnpm run build:github-pagesnpm run build:server