feat(moq-native): default QUIC backend to noq instead of quinn#1891
Merged
Conversation
Switch the default-compiled and default-selected QUIC backend from quinn to noq across moq-native and all binaries. quinn stays available as an opt-in `--features quinn` escape hatch. - moq-native: `default` feature -> noq; auto-detect priority now prefers noq over quinn when multiple backends are compiled. - Binaries (relay, cli, boy, bench, hls, rtc, srt) default to noq, each gaining a `noq` feature where it was missing. moq-ffi/libmoq/moq-gst inherit the new default via `default-features = true`. - Fix crypto-provider feature wiring: quinn routed its provider through `quinn?/rustls-aws-lc-rs` / `quinn?/rustls-ring`, but noq had no equivalent. web-transport-noq forced aws-lc-rs via its own defaults, so a `--features noq,ring` build silently pulled aws-lc-rs anyway. Set web-transport-noq `default-features = false` and route the provider through moq-native's aws-lc-rs/ring features, mirroring quinn. - Add a `noq=info` tracing directive alongside `quinn=info`; update docs. noq uses BBR3 congestion control by default (quinn ran default CUBIC with a TODO to validate BBR), so the effective default congestion controller changes to BBR3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kixelated
force-pushed
the
claude/friendly-wright-c6dc9f
branch
from
766ccc6 to
126ee01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the default-compiled and default-selected QUIC backend from quinn to noq across
moq-nativeand all binaries.quinnstays available as an opt-in--features quinnescape hatch, so nothing is removed.client.rs,server.rs): flipped the auto-detect priority sonoqwins when multiple backends are compiled (wasquinn > noq > quiche, nownoq > quinn > quiche).noq, adding anoqfeature where it was missing:moq-relay,moq-cli,moq-boy,moq-bench,moq-hls,moq-rtc,moq-srt,moq-rtmp.moq-ffi,libmoq, andmoq-gstinherit the new default viadefault-features = true.quinn?/rustls-aws-lc-rs/quinn?/rustls-ring, but noq had no equivalent.web-transport-noqforcedaws-lc-rsvia its own default features, so a--features noq,ringbuild silently pulled in aws-lc-rs anyway. Setweb-transport-noqdefault-features = false(workspace root) and route the provider through moq-native'saws-lc-rs/ringfeatures, exactly mirroring quinn.noq=infotracing directive alongsidequinn=info; updateddoc/lib/rs/...to name noq as the default.Behavioral notes
TODO: validate BBR before enabling). So the effective default congestion controller for the project is now BBR3.web-transport-noqis 0.2.0 andnoqis 1.0.0, both younger than the battle-testedweb-transport-quinn 0.11/quinn. Functionality is at parity (mTLS, preferred_address, QUIC-LB CID generation, bloom/retry, platform-verifier all present and tested).Public API / breaking-change notes
No public Rust API signatures change. This is a default-feature + wire-stack swap, hence targeting dev: release binaries (moq-relay, moq-cli) now ship noq by default, and the default congestion controller changes.
Test plan
cargo check --workspace(default = noq) cleanmoq-nativequinn opt-in still builds (--no-default-features --features quinn,aws-lc-rs,websocket)--features noq,ring,websocketnow builds correctly (previously mis-wired)noq_raw_quic,noq_webtransport,noq_mtlstaplo format --check+cargo fmt --check(via nix) clean(Written by Claude)