fix(quote-search): quote length description is incorrect for some languages (@Leonabcd123)

[Leonabcd123]

Fixes #8081.

[fehmer]

Hi @Leonabcd123,

we have the translation from quote.group to a in multiple places. Should we just add it to the Quote type on the frontend as e.g. groupDescriptionand map it once in the controller after reading the json file and check where we can use this instead of the number

[github-actions]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

[fehmer]

monkeytype/frontend/src/ts/test/result.ts

Line 787 in 6f16874

testType += ` ${["short", "medium", "long", "thicc"][randomQuote.group]}`;

should use the new groupDescriptionas well

[fehmer]

monkeytype/frontend/src/ts/collections/results.ts

Line 500 in 6f16874

...valueFilter(filters.quoteLength, {

does the reverse mapping, would be great if we use one source for it

[fehmer]

monkeytype/frontend/src/ts/components/modals/MobileTestConfigModal.tsx

Line 23 in 6f16874

const quoteLengths: {

another one

[fehmer]

and another :)

monkeytype/frontend/src/ts/components/pages/test/TestConfig.tsx

Line 306 in 6f16874

const quoteLengths = [

[suzunn]

I noticed one runtime regression in the current reverse-map shape. groupToDesc is built with Object.entries(descToGroup).map(...) and then cast to Record<number, QuoteLength>, but the cast does not change the runtime value. That leaves groupToDesc[0] as a tuple like [0, short] instead of the string short, so getLengthDesc() can assign an array to groupDescription and the UI can render 0,short instead of short.

I would change that reverse map to Object.fromEntries(Object.entries(descToGroup).map(([desc, group]) => [group, desc])) and add a small assertion around the controller result for a quote in group 0/1. That should keep the schema source of truth while catching this specific runtime/type-cast mismatch.

[Leonabcd123]

I noticed one runtime regression in the current reverse-map shape. groupToDesc is built with Object.entries(descToGroup).map(...) and then cast to Record<number, QuoteLength>, but the cast does not change the runtime value. That leaves groupToDesc[0] as a tuple like [0, short] instead of the string short, so getLengthDesc() can assign an array to groupDescription and the UI can render 0,short instead of short.

I would change that reverse map to Object.fromEntries(Object.entries(descToGroup).map(([desc, group]) => [group, desc])) and add a small assertion around the controller result for a quote in group 0/1. That should keep the schema source of truth while catching this specific runtime/type-cast mismatch.

Fixed in ed50376.

[github-actions]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.