Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the nightly release workflow dispatch failure by removing an invalid ref value (a bare commit SHA) used when dispatching npm-publish.yml, aligning with GitHub Actions’ requirement that the dispatch ref be a branch or tag. This keeps the publish workflow definition sourced from main, while still pinning the published source via the ref="${{ github.sha }}" input to npm-publish.yml.
Changes:
- Remove
DISPATCH_WORKFLOW_REF: ${{ github.sha }}from the nightly release workflow’s dispatch step. - Rely on
.github/scripts/dispatch-and-wait.mjsdefault behavior (main) for the workflow-definition ref while continuing to pass the commit SHA as an input tonpm-publish.yml.
nbbeeken
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
The first nightly run after #4930 was merged failed immediately with:
Root cause:
DISPATCH_WORKFLOW_REF: ${{ github.sha }}was set based on a reviewer suggestion to pin the workflow file to the exact commit being published. However, the GitHub Actions dispatch API (POST /actions/workflows/{id}/dispatches) requires a branch or tag name as ref - bare commit SHAs are not accepted.Fix: Remove
DISPATCH_WORKFLOW_REF. The script (dispatch-and-wait.mjs) already defaults tomain, which is correct:npm-publish.ymlis taken frommain.The underlying concern (provenance diverging from published source) is already addressed by the separate
ref="${{github.sha }}"input passed tonpm-publish.yml, which pins the checkout - and therefore the provenance attestation - to the exact commit being published.DISPATCH_WORKFLOW_REFonly controls which branch the workflow definition is loaded from, not what source is built.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript