Generalize find_route to take RouteParameters#32
Merged
amackillop merged 1 commit intoMay 22, 2026
Merged
Conversation
The previous find_route(payee, amount_msat, params) signature built PaymentParameters::from_node_id internally, throwing away the private route hints carried in BOLT11 invoices and the blinded payment paths carried in BOLT12 invoices. The underlying router handles both shapes fine; the API was hiding them. Callers now build RouteParameters themselves with the appropriate PaymentParameters::from_* constructor and pass it in. The node-wide RouteParametersConfig is no longer overlaid implicitly. Different destination shapes want different caps, and overlaying the clear- pubkey defaults onto invoice-derived params would clobber the hint and blinded-path data the new API is meant to preserve. PaymentParameters and RouteParameters are re-exported from lightning::routing::router so callers do not pull in rust-lightning directly.
martinsaposnic
approved these changes
May 22, 2026
amackillop
merged commit f13fcea
into
lsp-0.7.0_accept-underpaying-htlcs_with_timing_logs
6 of 34 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous find_route(payee, amount_msat, params) signature built PaymentParameters::from_node_id internally, throwing away the private route hints carried in BOLT11 invoices and the blinded payment paths carried in BOLT12 invoices. The underlying router handles both shapes fine; the API was hiding them.
Callers now build RouteParameters themselves with the appropriate PaymentParameters::from_* constructor and pass it in. The node-wide RouteParametersConfig is no longer overlaid implicitly. Different destination shapes want different caps, and overlaying the clear- pubkey defaults onto invoice-derived params would clobber the hint and blinded-path data the new API is meant to preserve.
PaymentParameters and RouteParameters are re-exported from lightning::routing::router so callers do not pull in rust-lightning directly.